Merge pull request #330 from fwbrasil/opt-uri-token-decoding

optimize uri parsing to reduce StringBuilder allocations
softwaremill · Mar 5, 2024 · 45466f4 · 45466f4
2 parents 4df0e52 + 2aae990
commit 45466f4
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/core/src/main/scala/sttp/model/UriInterpolator.scala b/core/src/main/scala/sttp/model/UriInterpolator.scala
@@ -731,6 +731,16 @@ object UriInterpolator {
             case Singleton(ExpressionToken(s: Array[_])) =>
               b ++= s.flatMap(anyToStringOpt)
               doToSeq(tailTs)
+            case valueTs if(valueTs.size == 1) =>
+              // This case is equivalent to the next one but optimizes for the 
+              // frequent scenario where the sequence contains a single element.
+              valueTs.get(0) match {
+                case StringToken(s)     => b += decode(s, decodePlusAsSpace)
+                case ExpressionToken(e) => anyToStringOpt(e).foreach(b += _)
+                case EqInQuery          => b += "="
+                case _                  => 
+              }
+              doToSeq(tailTs)
             case valueTs =>
               val mbStr = valueTs mkStringOpt {
                 case StringToken(s)     => Some(decode(s, decodePlusAsSpace))