This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
stake-pool: Remove mpl crate dependency for 1.16 upgrade #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because of circular dependencies between SPL and Metaplex Token Metadata, the SPL can't upgrade to Solana 1.16.
Solution
After trying many different options, nothing can be done directly at the source level, except for splitting out stake pools into their own repo.
This goes one of the lazy routes, and directly inlines the bits needed for metadata support in the stake pool program. If this looks ok, I'll do the same for single pools.
While implementing this, I first did just the program to make sure that everything worked exactly the same from the outside, and then I removed the mpl dependency from the tests.