This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
release: Bump token-2022 and all dependencies #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Sep 1, 2023
| @@ -16,4 +16,4 @@ solana-program-test = "1.16.3" | |||
| solana-sdk = "1.16.3" | |||
| spl-associated-token-account = { version = "2.0", path = "../program", features = ["no-entrypoint"] } | |||
| spl-token = { version = "4.0", path = "../../token/program", features = ["no-entrypoint"] } | |||
| spl-token-2022 = { version = "0.7", path = "../../token/program-2022", features = ["no-entrypoint"] } | |||
| spl-token-2022 = { version = "0.8", path = "../../token/program-2022", features = ["no-entrypoint"] } | |||
There was a problem hiding this comment.
Not bumping associated token account crate?
There was a problem hiding this comment.
I don't think we have a reason to release it, do we?
There was a problem hiding this comment.
Maybe not. Bumping one of it's dependencies isn't grounds to release it? Because no code has changed within it right? As long as we're not re-exporting token 2022 then it's cool
There was a problem hiding this comment.
oh wait never mind, you're absolutely right. token-client and token-cli use associated-token-account
There was a problem hiding this comment.
side note: this is why just having everything on the same version and releasing them as one simplifies a lot
|
I left some comments on crates you didn't bump. I see you're focused on only what token2022 depends on, but I am curious how/when we plan to publish crates for the others if the gang's all getting bumped |
In order to release a new token-2022, we need to bump its version and every local crate that it depends on. That means the following: * spl-token-2022 * spl-program-error * spl-tlv-account-resolution * spl-type-length-value * spl-token-metadata-interface * spl-token-metadata-example * spl-transfer-hook-interface * spl-transfer-hook-example * spl-token-client (this one's not needed, but it's cleaner)
thlorenz
added a commit
to ironforge-cloud/solana-program-library
that referenced
this pull request
Sep 4, 2023
* master: (719 commits) release: Bump token-2022 and all dependencies (solana-labs#5189) SPL errors from hashes (solana-labs#5169) stake-pool: Add comments about unnecessary ownership checks (HAL-01) (solana-labs#5084) stake-pool: Enforce that pool mint uses 9 decimal places (HAL-03) (solana-labs#5085) build(deps-dev): bump tsx from 3.12.7 to 3.12.8 in /single-pool/js (solana-labs#5188) account-compression: Fixup sdk doc deployment (solana-labs#5187) token-js: renamed `getExtraAccountMetaAccount` to `getExtraAccountMetaAddress` (solana-labs#5186) token-js: added an e2e test for transferring using a mint with a transfer hook extension (solana-labs#5138) Serde optional dependencies clean-up (solana-labs#5181) build(deps): bump chrono from 0.4.27 to 0.4.28 (solana-labs#5180) stake-pool: Use unaligned types for safe pointer cast (solana-labs#5179) spl-pod: make code docs more explicit (solana-labs#5178) token-js: added extra account resolution for transfer hook extension (solana-labs#5112) Fix incorrect code doc (solana-labs#5177) Move Pod types to separate library (solana-labs#5119) build(deps-dev): bump @typescript-eslint/eslint-plugin from 6.4.1 to 6.5.0 in /memo/js (solana-labs#5176) build(deps): bump chrono from 0.4.26 to 0.4.27 (solana-labs#5171) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token-swap/js (solana-labs#5174) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token/js (solana-labs#5172) build(deps-dev): bump prettier from 3.0.2 to 3.0.3 in /token-lending/js (solana-labs#5173) ...
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to release a new token-2022, we need to bump its version and every local crate that it depends on. That means the following: