This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
stake-pool: add new version of DecreaseValidatorStake to use reserve, add compatibility with master
#5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
changed the title
DecreaseValidatorStake to use reserve, add compatibility with master
|
noting to myself the commit moved to b482537 |
Ah darn, sorry about that. Yes, exactly. |
This was referenced Sep 22, 2023
2501babe
previously approved these changes
Sep 22, 2023
mergify
bot
dismissed
2501babe’s stale review
Pull request has been modified.
|
Merging before all checks are finished -- the test-sbf section did pass |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR builds on #5288, starting with b482537
Problem
To adapt stake pools to the upcoming changes in solana-labs/solana#33295, stake pools need to pre-fund the rent-exempt reserve during splits in
DecreaseValidatorStake.Solution
The first commit b482537 is the meat of the change which adds a new instruction to use the reserve, deprecates the old one. And the rest of the commits fix the tests.
I tested this with #5285 against the monorepo master, and everything passes!