This repository was archived by the owner on Jan 22, 2025. It is now read-only.
remove unwraps in alt_bn128 syscall #28955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
changed the title
Lichtso
approved these changes
Nov 25, 2022
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
removed unwraps in alt_bn128 syscall
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unwraps in syscalls can cause the local test validator to panic. The alt_bn128 syscall #27961 also uses unwraps.
You can reproduce the issue by passing in e.g. little endian bytes instead of big endian bytes.
This is difficult to catch in unit tests since tests for invalid inputs pass and don’t easily account for the the validator crashing.
Summary of Changes
Removed all unwraps in alt_bn128 syscalls.
Fixes #