Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Fixed reqwest json issue #8470

Closed
wants to merge 1 commit into from
Closed

Conversation

vkomenda
Copy link
Contributor

Problem

error[E0599]: no method named `json` found for type `reqwest::blocking::request::RequestBuilder` in the current scope
  --> watchtower/src/notifier.rs:50:57
   |
50 |             if let Err(err) = self.client.post(webhook).json(&data).send() {
   |                                                         ^^^^ method not found in `reqwest::blocking::request::RequestBuilder`

Summary of Changes

Added the json feature to reqwest in Cargo.toml.

@mvines mvines added the CI Pull Request is ready to enter CI label Feb 26, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #8470 into v0.23 will decrease coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           v0.23   #8470     +/-   ##
=======================================
- Coverage   80.6%   80.6%   -0.1%     
=======================================
  Files        251     251             
  Lines      55273   55273             
=======================================
- Hits       44588   44586      -2     
- Misses     10685   10687      +2

@mvines
Copy link
Contributor

mvines commented Feb 26, 2020

Wow I'm surprised that CI didn't catch this issue. I see why now, due to a crazy cargo feature interaction between multiple crates in the repository.

We'll want to make this change on the master branch first, and I see a couple other related fixes that are needed.

@mvines
Copy link
Contributor

mvines commented Feb 26, 2020

Obsoleted by #8475

@mvines mvines closed this Feb 26, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants