Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate OboeSettings.type and .layer #8

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

swi-jared
Copy link
Contributor

Also add clarity to .ttl

Also add clarity to `.ttl`
collector.proto Outdated Show resolved Hide resolved
@cheempz
Copy link
Contributor

cheempz commented Jul 19, 2024

@swi-jared the ttl clarification (actually needed to know that recently!) and deprecation markers are great, would love to get this in when you have time to address @jerrytfleung's comment and turn it into ready for review.

@swi-jared swi-jared marked this pull request as ready for review July 23, 2024 21:56
@swi-jared swi-jared requested a review from a team as a code owner July 23, 2024 21:56
Copy link
Contributor

@jerrytfleung jerrytfleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swi-jared swi-jared merged commit 410bbdb into main Jul 25, 2024
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants