NH-65713 Add configurator trace exporter tests #225
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit e531780.
| from solarwinds_apm import configurator | ||
|
|
||
| # otel fixtures | ||
| from .fixtures.batch_span_processor import fixture_mock_bsprocessor |
Check notice
Code scanning / CodeQL
Unused import
| from .fixtures.apm_config import ( | ||
| fixture_mock_apmconfig_disabled, | ||
| fixture_mock_apmconfig_enabled, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
| from .fixtures.extension import ( | ||
| fixture_mock_reporter, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
| from .fixtures.extension import ( | ||
| fixture_mock_reporter, | ||
| ) | ||
| from .fixtures.fwkv_manager import fixture_mock_fwkv_manager |
Check notice
Code scanning / CodeQL
Unused import
| fixture_mock_reporter, | ||
| ) | ||
| from .fixtures.fwkv_manager import fixture_mock_fwkv_manager | ||
| from .fixtures.meter_manager import fixture_mock_meter_manager |
Check notice
Code scanning / CodeQL
Unused import
| ) | ||
| from .fixtures.fwkv_manager import fixture_mock_fwkv_manager | ||
| from .fixtures.meter_manager import fixture_mock_meter_manager | ||
| from .fixtures.txn_name_manager import fixture_mock_txn_name_manager |
Check notice
Code scanning / CodeQL
Unused import
There was a problem hiding this comment.
LGTM, great to see the foundations you've added for testing @tammy-baylis-swi! Left a question that may be my misreading, but it seems if exporter isn't explicitly set we should default to the solarwinds one?
| ) | ||
| mock_bsprocessor.assert_not_called() | ||
| mock_get_tracer_provider.assert_not_called() | ||
| mock_add_span_processor.assert_not_called() |
There was a problem hiding this comment.
For this traces_exporter_none test, does it mean if OTEL_TRACES_EXPORTER env var is not set, our custom distro does not configure the solarwinds_exporter either?
There was a problem hiding this comment.
Ooh yes good question.
For _configure_traces_exporter in complete isolation, yes it could be that OTEL_TRACES_EXPORTER is None so this test is for that scenario.
For _configure_traces_exporter running at distro startup, that scenario shouldn't happen. SolarWindsDistro._configure is called first to set env var defaults. Outside lambda the default is the SW exporter. Then SolarWindsConfigurator._configure is called to init the exporters etc. If OTEL_TRACES_EXPORTER wasn't set by user, then default from distro is used instead.
There was a problem hiding this comment.
Ah gotcha, thanks for the pointers :)
tammy-baylis-swi
deleted the
NH-65713-add-configurator-exporter-tests
branch
Adds unit tests for configurator's
_configure_traces_exporterfunction. Includesfixtures/that I'll re-use for other configurator tests in next PRs.Does a teeny src code change so that the
Failed to loadmessage doesn't print out info originating from env var anymore (the ApmConfig agent_enabled method does it this way).Last test run at 4b35b69 passed with c-lib 14. Then fails again with revert, like #224