fix: store fetchEvent in h3 context

[katywings]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• infrastructure changes
• Other... Please describe:

What is the current behavior?

getFetchEvent is flaky, creating & storing multiple fetchEvents per h3Event. The reason for this is vinxi duplicating the code including the fetchEventSymbol per router (nksaraf/vinxi#51), e.g. if you console.log the symbol

solid-start/packages/start/src/server/fetchEvent.ts

Line 16 in 23b01da

const fetchEventSymbol = Symbol("fetchEvent");

you will notice that the console.log is executed twice during startup. Also if you log Object.getOwnPropertySymbols(h3Event) in getFetchEvent you get [ Symbol(fetchEvent), Symbol(fetchEvent) ] on requests that affect multiple vinxi routers.

What is the new behavior?

getFetchEvent will maximally create one fetchEvent per h3Event by storing the fetchEvent in h3Event.context. h3Event is stable across multiple routers and h3Event.context is specifically made for situations like this as @pi0 already confirmed in an other thread (#1203 (comment)).

[changeset-bot]

🦋 Changeset detected

Latest commit: 8515f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solidjs/start	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Run & review this pull request in StackBlitz Codeflow.

commit: 8515f2b

@solidjs/start

npm i https://pkg.pr.new/@solidjs/start@1586

---

templates

• example-bare
• example-basic
• example-experiments
• example-hackernews
• example-notes
• example-todomvc
• example-with-auth
• example-with-authjs
• example-with-drizzle
• example-with-mdx
• example-with-prisma
• example-with-solid-styled
• example-with-tailwindcss
• example-with-trpc
• example-with-unocss
• example-with-vitest

[boehs]

lgtm, but why are symbols no longer being used? I assume the context supports them?

[katywings]

@boehs You can think of the symbol like an object, when you create one its always a new one. And there exist multiple ones because vinxi duplicates the code.

Maybe this helps to explain:

Symbol("foo") === Symbol("foo"); // false
"foo" === "foo" // true

[ryansolid]

Interesting. Well good catch.