Make SAI attrs mandatory for drop-on-miss tables #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table references another table (ENI->VNET_ID) where VNET table drops on miss, the SAI attribute VNET_ID in the ENI will be mandatory on create. Omitting this attribute will no longer be allowed. Signed-off-by: Marian Pritsak <marianp@mellanox.com>
|
Requires opencomputeproject/SAI#1616 and also ported to dash branch. |
| @@ -403,6 +422,8 @@ def write_sai_files(sai_api): | |||
| for table_name in all_table_names: | |||
| if table_ref.endswith(table_name): | |||
| param[OBJECT_NAME_TAG] = table_name | |||
| if is_table_deny_on_miss(sai_apis, table_name): | |||
There was a problem hiding this comment.
I would prefer this logic not be buried in the API generator. Can we use a P4 annotation instead?
|
@marian-pritsak is this obsolete? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table references another table (ENI->VNET_ID) where VNET table drops on miss, the SAI attribute VNET_ID in the ENI will be mandatory on create.
Omitting this attribute will no longer be allowed.
Signed-off-by: Marian Pritsak marianp@mellanox.com