Support SAi attr generation from annotattions #358
Conversation
|
@marian-pritsak please sync to main, a cascade of PRs yesterday caused a regression in a test case, the fix was just merged minutes ago. The failure in your CI pipeline should go away. |
There was a problem hiding this comment.
This is a worthwhile enhancement to the code generator, thanks. Please see comments regarding annotation naming conventions.
Also, It would be nice to start a README.md under dash-pipeline/bmv2 and start documenting some of our conventions, such as the proper usage of these annotations. We can build it up over time. This would be in line with #156.
Add support for @Sai[] structured annotations for table keys and action parameters. If not available, the old way is still valid till all params and keys will be annotated. Signed-off-by: Marian Pritsak <marianp@mellanox.com>
marian-pritsak
force-pushed
the
annotations
branch
from
864d008 to
42a00ef
Compare
|
@KrisNey-MSFT we can merge this |
|
@chrispsommers is there a way for spellcheck to omit terms like "isresourcetype" and not flag them? |
The only way I know of is to enclose in backticks. Kind of a pain. |
|
Please add a description paragraph that can cover what is this change and why it is needed. This helps during review of the PRs. Thanks. |
|
@KrisNey-MSFT This PR is ready for merging |
Add support for @Sai[] structured annotations for
table keys and action parameters. If not available, the old
way is still valid till all params and keys will be annotated.