Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[sonic-cfg]: Vlan names from the minigraph could be incompatible with SONiC Vlan interfaces naming schema #1003

Closed
pavel-shirshov opened this issue Oct 2, 2017 · 1 comment · Fixed by #1367
Closed

[sonic-cfg]: Vlan names from the minigraph could be incompatible with SONiC Vlan interfaces naming schema #1003

pavel-shirshov opened this issue Oct 2, 2017 · 1 comment · Fixed by #1367
Assignees
@pavel-shirshov @taoyl-ms
Labels
Bug 🐛

Comments

@pavel-shirshov
Copy link
Contributor

pavel-shirshov commented Oct 2, 2017 •
edited
Loading

SONiC supports Vlan interface names in format "Vlan"+dot1Q tag.
So, usually SONiC vlan names are: Vlan1 (for vlan tag 1), Vlan10 (for vlan tag 10) and so on.
Currently sonic-cfg takes a Vlan interface names from the minigraph VlanInterface["Name"] field. But it can contains a vlan name in incompatible format, like "Computers".
So right way to create a vlan name is to use "Vlan" + VlanInterface['Tag"].
@pavel-shirshov pavel-shirshov changed the title [sonic-cfg]: Use [sonic-cfg]: Vlan names from the minigraph could be incompatible with SONiC Vlan interfaces naming schema Oct 2, 2017
@taoyl-ms taoyl-ms mentioned this issue Oct 6, 2017
Closed
@taoyl-ms
Copy link
Contributor

taoyl-ms commented Feb 3, 2018 •
edited
Loading

Solved in #695 and #1367.

@taoyl-ms taoyl-ms mentioned this issue Feb 3, 2018
Merged
@stepanblyschak stepanblyschak mentioned this issue Dec 20, 2019
Merged
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue Dec 20, 2019
[swss] submodule update
e30258b 
9f6efa0 [port/buffer] introduce a sync mechanism to protect port
PG/queue from changes under PFC storm (sonic-net#1143)
823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (sonic-net#1146)
b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (sonic-net#1139)
03be983 Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP
implementation (sonic-net#1132)
efe142a Fix bug: Wrong condition for mac address (sonic-net#1142)
7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id
from saved lacp-pdu (sonic-net#1003)
8b4cfb6 Cleanup configure.ac from BFN specific code (sonic-net#1133)
b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler
init failure (sonic-net#854)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan pushed a commit that referenced this issue Dec 27, 2019
@stepanblyschak @lguohan
[swss] submodule update (#3925)
18cb5c6 
9f6efa0 [port/buffer] introduce a sync mechanism to protect port
PG/queue from changes under PFC storm (#1143)
823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (#1146)
b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (#1139)
03be983 Increase ip2me CIR/CBR for faster in-band file transfers (#1000)
a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP
implementation (#1132)
efe142a Fix bug: Wrong condition for mac address (#1142)
7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id
from saved lacp-pdu (#1003)
8b4cfb6 Cleanup configure.ac from BFN specific code (#1133)
b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler
init failure (#854)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@shine4chen @pavel-shirshov
[teammgrd]during warm-reboot teamd need to recover system-id from sav…
7bf63a0 
…ed lacp-pdu (sonic-net#1003)

* during warm-reboot teamd need to use same system-id before warm-reboot

Signed-off-by: shine.chen <shine.chen@nephosinc.com>

* refine per review comment

Signed-off-by: shine.chen <shine.chen@mediatek.com>
@Pterosaur Pterosaur mentioned this issue Feb 22, 2022
Merged
6 tasks
Pterosaur added a commit that referenced this issue Feb 23, 2022
@Pterosaur
[submodule]: Update sonic-sairedis (#10061)
937ffbd 
Signed-off-by: Ze Gan <ganze718@gmail.com>

b9337dc (HEAD, origin/master, origin/HEAD) [vslib]: Fix MACsec bug in SCI and XPN (#1003)
edbceb9 [syncd][vslib] Keep new warm boot discovered SERDES objects (#985)
af5c156 Fix build issues on gcc-10 (#999)
1445cd5 update SAI submoule (#1001)
48fe704 [ci] pipeline fixes for VS test (#1002)
f484cf9 Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (#975)
5d0b22d Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute (#975)
1b8ce97 (origin/202111) [pipeline] Download swss common artifact in a separated directory (#995)
7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (#992)
judyjoseph added a commit that referenced this issue Feb 28, 2022
@judyjoseph
update sonic-sairedis
c6774ad 
5331ecd [vslib]: Fix MACsec bug in SCI and XPN (#1003)
ac04509 Fix build issues on gcc-10 (#999)
1b8ce97 [pipeline] Download swss common artifact in a separated directory (#995)
7a2e096 Change sonic-buildimage.vs artifact source from CI build to official build. (#992)
d5866a3 [vslib]: fix create MACsec SA error (#986)
f36f7ce Added Support for enum query capability of Nexthop Group Type. (#989)
323b89b Support for MACsec statistics (#892)
26a8a12 Prevent other notification event storms to keep enqueue unchecked and drained all memory that leads to crashing the switch router (#968)
0cb253a Fix object availability conversion (#974)
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this issue Apr 14, 2022
@Pterosaur
[vslib]: Fix MACsec bug in SCI and XPN (sonic-net#1003)
b9337dc
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@pavel-shirshov pavel-shirshov

@taoyl-ms taoyl-ms

Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VLAN_INTERFACE attach issue upon vlan id-name mismatch taoyl-ms/sonic-buildimage
2 participants
@pavel-shirshov @taoyl-ms