Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Gateway IP address is always x.x.x.1 if setup ManagementIPInterface in minigraph.xml #857

Closed
okanchou9 opened this issue Jul 31, 2017 · 1 comment
Closed

Gateway IP address is always x.x.x.1 if setup ManagementIPInterface in minigraph.xml #857

okanchou9 opened this issue Jul 31, 2017 · 1 comment
Assignees
@taoyl-ms
Labels
Enhancement ➕ Question ❓

Comments

@okanchou9
Copy link

okanchou9 commented Jul 31, 2017 •
edited
Loading

Hi,

Opening an issue base on https://groups.google.com/forum/#!topic/sonicproject/AC30lG0qiPs and please refer the following for copy of original message:

Just found out that the IP address of gateway is always x.x.x.1 if setup ManagementIPInterface in minigraph.xml by the following line in minigraph.py:

gwaddr = ipaddress.IPAddress(int(mgmtipn.network) + 1)

I don't think this is a good way to hardcore this address since the IP address of gateway in different network topology may not x.x.x.1.
Suggest adding a new tag for it like the following sample xml format:

<a:ManagementIPInterface>
HostIP
eth0
<a:Prefix xmlns:b="Microsoft.Search.Autopilot.Evolution">
<b:IPPrefix>100.0.0.30/24</b:IPPrefix>
</a:Prefix>
<a:PrefixStr>100.0.0.30/24</a:PrefixStr>
100.0.0.254
</a:ManagementIPInterface>

Any suggestions would be helpful and let me know if any problem.

Regards,
Kenie Liu
@okanchou9 okanchou9 mentioned this issue Apr 13, 2018
Open
@taoyl-ms
Copy link
Contributor

Specifying gateway is not supported in minigraph schema. Please use gwaddr attribute in MGMT_INTERFACE table in config db to config this.

stcheng pushed a commit to stcheng/sonic-buildimage that referenced this issue May 9, 2019
[swss]: Update sonic-swss submodule
d91cb4d 
[vnetorch]: Use metadata matching for tunnel (sonic-net#841)
[aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868)
[restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862)
[intfsorch] Fix bug for VRF existence check (sonic-net#882)
Return 0 for CRM counter instead of None if no match (sonic-net#879)
Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857)
[Makefile]: Remove header files from source files (sonic-net#883)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng stcheng mentioned this issue May 9, 2019
Merged
prsunny pushed a commit that referenced this issue May 10, 2019
@prsunny
[swss]: Update sonic-swss submodule (#2879)
f32243b 
[vnetorch]: Use metadata matching for tunnel (#841)
[aclorch]: Add ICMP type/code match for v4/v6 (#868)
[restore_neighbors] fix failure with scapy 2.4.2 (#862)
[intfsorch] Fix bug for VRF existence check (#882)
Return 0 for CRM counter instead of None if no match (#879)
Undo skipping Vnet tests, Vrf check before enslaving (#857)
[Makefile]: Remove header files from source files (#883)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this issue May 28, 2019
@MichelMoriniaux
[swss]: Update sonic-swss submodule (sonic-net#2879)
aa83569 
[vnetorch]: Use metadata matching for tunnel (sonic-net#841)
[aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868)
[restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862)
[intfsorch] Fix bug for VRF existence check (sonic-net#882)
Return 0 for CRM counter instead of None if no match (sonic-net#879)
Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857)
[Makefile]: Remove header files from source files (sonic-net#883)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@prsunny
Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857)
015fc62 
* Undo skipping Vnet tests, VxlanMgrd merged to master

* Check VRF name before setting as master
@jleveque jleveque mentioned this issue Apr 28, 2020
Merged
lguohan pushed a commit that referenced this issue Apr 29, 2020
@jleveque
[sonic-utilities] Update submodule (#4492)
0895033 
* src/sonic-utilities 798ce2f...7ce5b62 (19):
  > [utility] Filter FDB entries (#890)
  > [fast reboot] set a fast-reboot DB flag (#887)
  > [show] Add 'ip/ipv6 bgp network' commands (#888)
  > [Vxlan] : adding show vnet/vxlan cmds (#880)
  > [show][bgp] Use only 'show ip bgp' as the base and use bgp_frr_v4 file for FRR routing stack (#884)
  > Revert "[config] Implement a process level lock (#857)" (#882)
  > [generate_dump] Dump systemd specific information (#602)
  > [config] Implement a process level lock (#857)
  > [fwutil]: Update Command-Reference.md. (#876)
  > Add platform options to 'show techsupport' command (#865)
  > [doc]: add ltgm and jenkins badge (#875)
  > Fix even more Python warnings (#873)
  > [showtech]: dump docker stats (#864)
  > Fix more Python warnings (#869)
  > Fix Python warnings (#867)
  > Fixes bug for PFCWD feature parameters (#838)
  > Explicitly specify command names with underscores (continued) (#852)
  > [watermarkstat] Fix issue of fields overwritten before display (#862)
  > [pfc] Add command line to enable/disable/show PFC (#796)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
[config] Implement a process level lock (sonic-net#857)
3f651dc 
Changes:
1.) Implement a class, which uses hsetnx for lock.
2.) lock is expired within timeout period or will be released by owner.
3.) After -y prompt, lock is reacquired, because timer could have expired,
    before user enters yes.
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
@lguohan
Revert "[config] Implement a process level lock (sonic-net#857)" (son…
a87173b 
…ic-net#882)

This reverts commit 3f651dc.
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this issue Apr 14, 2022
@kcudnik
[syncd] Fix fdb flood queue size limit check (sonic-net#857)
6fe1e75
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@taoyl-ms taoyl-ms

Labels
Enhancement ➕ Question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stcheng @okanchou9 @taoyl-ms