Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix AS7726 not showing serial number in 'show platform summary' (#10489) #10509

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix AS7726 not showing serial number in 'show platform summary' (#10489) #10509

merged 1 commit into from
Apr 20, 2022

Conversation

FuzailBrcm
Copy link
Contributor

Why I did it

AS7726 platform was not showing serial number in the output of

  • show platform summary
  • show version

Issue #10489

How I did it

Th root cause was that thePDDF chassis common class was reading the 'service_tag' upon invoking get_serial(). However, Accton platform AS7726 did not have service tag programmed in the EEPROM. Hence throwing 'N/A'. I changed the 'get_serial()' method to fetch the serial number of the board.

How to verify it

  • show platform summary
  • show platform version
root@sonic:/sys/bus/i2c/devices# show ver

SONiC Software Version: SONiC.master.0-dirty-20220408.025810
Distribution: Debian 11.3
Kernel: 5.10.0-8-2-amd64
Build commit: 50067c8e4
Build date: Fri Apr  8 10:03:36 UTC 2022
Built by: fk410167@sonic-lvn-csg-004

Platform: x86_64-accton_as7726_32x-r0
HwSKU: Accton-AS7726-32X
ASIC: broadcom
ASIC Count: 1
Serial Number: 772632X1911067
Model Number: FP3ZZ7632074A
Hardware Revision: N/A
Uptime: 10:54:30 up 17 min,  1 user,  load average: 0.87, 0.91, 0.82
Date: Fri 08 Apr 2022 10:54:30

Docker images:
REPOSITORY                    TAG                              IMAGE ID       SIZE
docker-platform-monitor       latest                           6d11a86a79be   519MB
docker-platform-monitor       master.0-dirty-20220408.025810   6d11a86a79be   519MB
docker-dhcp-relay             latest                           6134df8859e5   427MB
docker-sonic-telemetry        latest                           02f2bdff3ca6   506MB
docker-sonic-telemetry        master.0-dirty-20220408.025810   02f2bdff3ca6   506MB
docker-router-advertiser      latest                           4186dc554e53   417MB
docker-router-advertiser      master.0-dirty-20220408.025810   4186dc554e53   417MB
docker-database               latest                           f3ff7e7a38f5   417MB
docker-database               master.0-dirty-20220408.025810   f3ff7e7a38f5   417MB
docker-orchagent              latest                           38289831c04a   437MB
docker-orchagent              master.0-dirty-20220408.025810   38289831c04a   437MB
docker-fpm-frr                latest                           6c146abbc4f3   438MB
docker-fpm-frr                master.0-dirty-20220408.025810   6c146abbc4f3   438MB
docker-nat                    latest                           3a07c488cbc5   423MB
docker-nat                    master.0-dirty-20220408.025810   3a07c488cbc5   423MB
docker-sflow                  latest                           58c97022daf1   421MB
docker-sflow                  master.0-dirty-20220408.025810   58c97022daf1   421MB
docker-teamd                  latest                           77b13fe63153   420MB
docker-teamd                  master.0-dirty-20220408.025810   77b13fe63153   420MB
docker-macsec                 latest                           d3f757f29037   423MB
docker-macsec                 master.0-dirty-20220408.025810   d3f757f29037   423MB
docker-snmp                   latest                           87255f532f0b   449MB
docker-snmp                   master.0-dirty-20220408.025810   87255f532f0b   449MB
docker-syncd-brcm             latest                           0c1f4caa79f1   784MB
docker-syncd-brcm             master.0-dirty-20220408.025810   0c1f4caa79f1   784MB
docker-gbsyncd-credo          latest                           d2585339145a   422MB
docker-gbsyncd-credo          master.0-dirty-20220408.025810   d2585339145a   422MB
docker-lldp                   latest                           d4a5b441d5e6   445MB
docker-lldp                   master.0-dirty-20220408.025810   d4a5b441d5e6   445MB
docker-sonic-mgmt-framework   latest                           dc235a4f16fd   549MB
docker-sonic-mgmt-framework   master.0-dirty-20220408.025810   dc235a4f16fd   549MB
docker-mux                    latest                           dbcc3675685e   458MB
docker-mux                    master.0-dirty-20220408.025810   dbcc3675685e   458MB

root@sonic:/sys/bus/i2c/devices# show platform summary
Platform: x86_64-accton_as7726_32x-r0
HwSKU: Accton-AS7726-32X
ASIC: broadcom
ASIC Count: 1
Serial Number: 772632X1911067
Model Number: FP3ZZ7632074A
Hardware Revision: N/A
root@sonic:/sys/bus/i2c/devices#

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FuzailBrcm FuzailBrcm requested a review from lguohan as a code owner April 8, 2022 11:17
@FuzailBrcm
Copy link
Contributor Author

FuzailBrcm commented Apr 11, 2022 •
edited
Loading

/azpw run

1 similar comment
@FuzailBrcm
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@FuzailBrcm
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 10509 in repo Azure/sonic-buildimage

@FuzailBrcm
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jostar-yang
Copy link
Contributor

The modification is ok to me.

@FuzailBrcm
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested a review from vdahiya12 April 13, 2022 17:14
@FuzailBrcm
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FuzailBrcm
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested a review from prgeor April 20, 2022 17:24
@prgeor prgeor merged commit 122cb90 into sonic-net:master Apr 20, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6004325: Manual merge github master to internal
19c4542 
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@prgeor prgeor prgeor approved these changes

@babukr babukr babukr approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@vdahiya12 vdahiya12 Awaiting requested review from vdahiya12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FuzailBrcm @mssonicbld @jostar-yang @prgeor @babukr