Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

YANG model for FABRIC_MONITOR|FABRIC_MONITOR_DATA #14390

Merged

Conversation

jfeng-arista
Copy link
Contributor

Why I did it

Table FABRIC_MONITOR|FABRIC_MONITOR_DATA in CONFIG_DB was added in #14170
The YANG model for that table is still missing.

Need to wait #14170 get merged first.

How I did it

Added new YANG model FABRIC_MONITOR and associated unit tests.

How to verify it

Passing unit tests

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)


container FABRIC_MONITOR_DATA {

leaf monErrThreshCrcCells {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we a description to the leaf nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@jfeng-arista
Copy link
Contributor Author

/Azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 771a0d0 into sonic-net:master May 15, 2023
@gechiang
Copy link
Collaborator

@jfeng-arista , @arlakshm , Should this PR be labeled for chassis branch as well as 202305? Any other branch should this be picked up as well?

@gechiang gechiang added Chassis for 202205 branch PRs needed for 202205 branch in msft repo Request for 202211 Branch labels Jun 23, 2023
@gechiang
Copy link
Collaborator

@jfeng-arista , I am not able to cleanly cherry-pick this into the "https://github.com/Azure/sonic-buildimage-msft.git" 202205.
Can you please create a new PR in "https://github.com/Azure/sonic-buildimage-msft.git" repo under the 202205 branch for this exact change and tag me to review/approve/merge.
Thanks!

@jfeng-arista
Copy link
Contributor Author

will do, thank you

@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jul 28, 2023
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants