[bcm syncd]: Wait initializing led_proc for 60 seconds #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ady accept a connection
jleveque
approved these changes
Jul 16, 2018
|
retest this please |
|
Seems this is a bcmcmd bug and you mitigate it from outside. Could you just add a comment? |
|
Hi Qi, I think this is not a bug. It's a normal behavior just bcmcmd was run before the socket was ready to get connections. How bcmcmd could fix this? So I think it's better to wait as a quick fix. In the future we could add several attempts with exponentional backoff. |
|
retest this please |
yxieca
added a commit
that referenced
this pull request
Jul 19, 2018
* Wait initializing led_proc for 60 seconds. bcm sdk need time to be ready accept a connection
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a pause 60 seconds before initializing led processor. Otherwise bcmcmd will fail with error -5 in some cases.
- How I did it
sleep 60
- How to verify it
Build an image and run on your DUT
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)