-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Chassis][Voq][Yang] Make asic_name case sensitive in yang models #19486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xincunli-sonic
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abdosi
approved these changes
Jul 5, 2024
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
kenneth-arista
approved these changes
Jul 10, 2024
/Azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
10 tasks
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…nic-net#19486) * make asic_name case sensitive * address comment
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…nic-net#19486) * make asic_name case sensitive * address comment
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…nic-net#19486) * make asic_name case sensitive * address comment
Cherry-pick PR to 202405: #19792 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
…9486) * make asic_name case sensitive * address comment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Approved for 202405 Branch
Chassis for 202205 branch
PRs needed for 202205 branch in msft repo
Included in Chassis for 202205 Branch
Indicate PR is already in MSFT repo 202205 branch
Included in 202405 Branch
Request for 202405 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes #19485
Work item tracking
How I did it
Add a new typedef for
asic_name
and make the pattern case in sensitiveHow to verify it
UT and test on voq linecards
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202405 and 202205
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)