Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Chassis][Voq][Yang] Make asic_name case sensitive in yang models #19486

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Jul 5, 2024

Why I did it

Fixes #19485

Work item tracking
  • Microsoft ADO ** 28529095**:

How I did it

Add a new typedef for asic_name and make the pattern case in sensitive

How to verify it

UT and test on voq linecards

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

202405 and 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@arlakshm arlakshm requested a review from qiluo-msft as a code owner July 5, 2024 04:22
@arlakshm arlakshm requested review from kenneth-arista, xincunli-sonic and qiluo-msft and removed request for qiluo-msft July 5, 2024 04:23
@arlakshm arlakshm added Request for 202405 Branch Chassis for 202205 branch PRs needed for 202205 branch in msft repo labels Jul 5, 2024
Copy link
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arlakshm
Copy link
Contributor Author

arlakshm commented Jul 9, 2024

/Azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor Author

/Azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gechiang gechiang requested review from lguohan and rlhui July 13, 2024 22:25
@gechiang
Copy link
Collaborator

@rlhui , @lguohan , can you help review/merge this PR?

@rlhui rlhui merged commit e2b30cc into sonic-net:master Jul 13, 2024
22 checks passed
@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jul 13, 2024
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 2, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19792

mssonicbld pushed a commit that referenced this pull request Aug 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Chassis] Incremental config patch fails because the yang validation fails on voq chassis
8 participants