Revert "Revert suppress FIB pending feature" #19836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4397a85.
dgsudharsan
requested review from
StormLiangMS,
qiluo-msft and
lguohan
as code owners
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
|
hi @lipxu could you help to take a look? Or suggest which test we should have nVidia to run to take in this PR? |
Hi @StormLiangMS . We have run the entire sonic-mgmt test suite with these changes + zebra bgp enhancements. We found no issues. We also find memory doesn't increase with test_stress_route with 50 iterations. |
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
…-net#19836) Reverts sonic-net#19027 The support for BGP zebra enhancements is merged in sonic-net#19717. Hence re-enabling BGP suppress fib pending feature.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19027
The support for BGP zebra enhancements is merged in #19717. Hence re-enabling BGP suppress fib pending feature.