Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[platform-device/haliburton] Support xcvr and sensor monitoring #1998

Merged
merged 4 commits into from
Aug 29, 2018

Conversation

pphuchar
Copy link
Contributor

- What I did
Enchantment to support transceiver and sensors monitoring.

- How I did it
*Expose transceiver interrupt signals through sysfs.
*Implement get_transceiver_change_event in sfputil plugin.

- How to verify it
Run test on Haliburton platform.

- Description for the changelog

*Support transceiver and sensor monitoring on Haliburton platform.
*Fix kernel panic in SMC platform module, when removed.

@lguohan lguohan merged commit e8db184 into sonic-net:master Aug 29, 2018
@pphuchar pphuchar deleted the hlx-xcvr-event-monitor branch August 30, 2018 04:38
qiluo-msft pushed a commit that referenced this pull request Feb 22, 2022
```
Commits on Jan 31, 2022
[sonic-package-manager] implement blocking feature state change (#2035) 

Commits on Feb 12, 2022
[ci] pipeline fixes for VS test (#2059) 

Commits on Feb 14, 2022
[ci] allow download partially succeeded suilds for sonic-swss-pytests… 
[build] allowPartiallySucceededBuilds true in the step of download so… 

Commits on Feb 16, 2022
[config] Fix snmpagentaddress doesn't support the uppercase letters f… 

Commits on Feb 17, 2022
[ci] Fix pipeline on build_and_install_module (#2074) 
Enable diff coverage and set the threshold to 50% (#2061) 

Commits on Feb 18, 2022
check for adding default vlan attempt added (#2075) 
[GCU] Adding unit-test where path and ref paths are under the same YA… 
[GCU] Turning port admin down before some critical port changes (#1998) 

Commits on Feb 20, 2022
show_platfom_info not run for simx (#2042) 
[aclshow] fix aclshow when clear is called before counters are popula… 
```
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
…c-net#1998)

#### What I did
Fixes sonic-net#1930 

Issue can be summarized into these 2 case:
* A patch can contain an operation to turn port `admin up` -- do at the end
* A patch that modifies config that needs the port to be down -- start by bringing the port down then do the update then bring it back up

#### How I did it
The configs that need the port to be down, we will call them `critical-port` configs.

* Added a move validator to validate `critical-port` configs, which does the following
  * If a port is up, make sure the move does not make changes to related `critical-port` configs
  * If the move is turning a port up, make sure there is no `critical-port` config are still left in the patch

* Added a move extender to `critical-port` changes:
  * If a port is up, bring down if there are critical-port changes
  * If the move is turning a port up, flip it to down if there are still `critical-port` configs left. In other words, do not turn the port back up until all `critical-port` changes are in done.

#### How to verify it
* Added `AddRack` unit-test to `tests/generic_config_updater/files/patch_sorter_test_success.json`
* Other unit-tests

#### Previous command output (if the output of a command-line utility has changed)
Check issue sonic-net#1930 for old sorting order

#### New command output (if the output of a command-line utility has changed)
Check  `AddRack` unit-test to `tests/generic_config_updater/files/patch_sorter_test_success.json` for new sorting-order
vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants