Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[teamd] Force team device recreation in case it already exists #2168

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Oct 18, 2018

- What I did
I've added an option to recreate LAG interface by teamd if it already exist. Usually we need this if teamd crashed and didn't remove the LAG interface.

- How I did it
Added -r option for teamd start.

- How to verify it

  1. go inside teamd docker
  2. kill -9 $teamd_pid
  3. restart teamd - /usr/bin/teamd.sh.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Oct 18, 2018

there is

-r --force-recreate      Force team device recreation in case it already exists

should we use -r?

@lguohan
Copy link
Collaborator

lguohan commented Oct 18, 2018

since it is cold restart, I am thinking maybe it is more clean just to re-create the teamd device.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to force recreate

@pavel-shirshov pavel-shirshov changed the title [teamd] Take over the LAG device if it already exists [teamd] Force team device recreation in case it already exists Oct 18, 2018
@lguohan lguohan merged commit 3e1b9e1 into master Oct 18, 2018
lguohan pushed a commit that referenced this pull request Oct 18, 2018
* Force team device recreation in case it already exists
@pavel-shirshov pavel-shirshov deleted the pavelsh/teamd_use branch October 18, 2018 23:21
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Mar 13, 2022
0026689 Add AAA table description and example to Configuration.md (sonic-net#2168)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Ndancejic pushed a commit to Ndancejic/sonic-buildimage that referenced this pull request May 3, 2022
…2168)

**What I did**
    Add AAA table description and example to configuration.md 

**Why I did it**
   AAA table description and example are missing in configuration.md 

**How I verified it**
    No code change, not validate.

**Details if related**
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants