[Mellanox] Fix typo "xSFP_VLOT_OFFSET" #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
retest this please |
lguohan
approved these changes
Jul 5, 2019
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jan 13, 2024
Old format: version_a_b_c New format: version_<branch>_<nn> sonic-utilities: * 371d62a2 2024-01-13 | Revert "Enhanced route_check.py for multi_asic platforms (sonic-net#3077)" (HEAD -> master, github/ying-test-submodule-advance) [Ying Xie] * 7ddc709a 2024-01-13 | Revert "route_check: Skip route checks if bgp feature is not enabled (sonic-net#3075)" [Ying Xie] * 1489c727 2024-01-12 | [Techsupport]Adding more FRR and BGP dumps (sonic-net#3118) (github/master) [Sudharsan Dhamal Gopalarathnam] * 359e6925 2024-01-11 | Disable Key Validation feature during sonic-installation for Cisco Platforms (sonic-net#3115) [selvipal] * 9515c642 2024-01-04 | [chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC (sonic-net#3099) [Arvindsrinivasan Lakshmi Narasimhan] * 9400691c 2023-12-25 | Fix database initialization for db_migrator (sonic-net#3100) [ganglv] * 56dafb07 2023-12-25 | Support disable/enable syslog rate limit feature (sonic-net#3072) [Junchao-Mellanox] * 529bb96b 2023-12-23 | route_check: Skip route checks if bgp feature is not enabled (sonic-net#3075) [anamehra] * bcb10f18 2023-12-23 | Support golden config in db migrator (sonic-net#3076) [ganglv] * 20d1495b 2023-12-21 | [db_migrator] add db migrator version space for 202305/202311 branch (sonic-net#3081) [Ying Xie] * a68d3d3a 2023-12-20 | Collect module EEPROM data in dump (sonic-net#3009) [Junchao-Mellanox] * e7a8def6 2023-12-19 | Enhanced route_check.py for multi_asic platforms (sonic-net#3077) [Deepak Singhal] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Jan 15, 2024
…atically (#17573) #### Why I did it src/sonic-utilities ``` * 942a7c9e - (HEAD -> master, origin/master, origin/HEAD) Revert "Enhanced route_check.py for multi_asic platforms" (#3122) (2 minutes ago) [Ying Xie] * 01ee98ec - Revert "route_check: Skip route checks if bgp feature is not enabled" (#3121) (3 minutes ago) [Ying Xie] * 1489c727 - [Techsupport]Adding more FRR and BGP dumps (#3118) (2 days ago) [Sudharsan Dhamal Gopalarathnam] * 359e6925 - Disable Key Validation feature during sonic-installation for Cisco Platforms (#3115) (4 days ago) [selvipal] * 9515c642 - [chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC (#3099) (10 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * 9400691c - Fix database initialization for db_migrator (#3100) (3 weeks ago) [ganglv] * 56dafb07 - Support disable/enable syslog rate limit feature (#3072) (3 weeks ago) [Junchao-Mellanox] * 529bb96b - route_check: Skip route checks if bgp feature is not enabled (#3075) (3 weeks ago) [anamehra] * bcb10f18 - Support golden config in db migrator (#3076) (3 weeks ago) [ganglv] * 20d1495b - [db_migrator] add db migrator version space for 202305/202311 branch (#3081) (4 weeks ago) [Ying Xie] * a68d3d3a - Collect module EEPROM data in dump (#3009) (4 weeks ago) [Junchao-Mellanox] * e7a8def6 - Enhanced route_check.py for multi_asic platforms (#3077) (4 weeks ago) [Deepak Singhal] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Feb 5, 2024
…atically (#18025) #### Why I did it src/sonic-utilities ``` * 2046e66c - (HEAD -> 202311, origin/202311) Reduce generate_dump mem usage for cores (#3052) (3 days ago) [davidm-arista] * fbd6c916 - Disable Key Validation feature during sonic-installation for Cisco Platforms (#3115) (3 days ago) [selvipal] * 88c027f0 - [Techsupport]Adding more FRR and BGP dumps (#3118) (3 days ago) [Sudharsan Dhamal Gopalarathnam] * 555ecf64 - [chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC (#3099) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * 1515edcb - [db_migrator]Remove route migration (#3068) (3 days ago) [Sudharsan Dhamal Gopalarathnam] * 8862c114 - Modify teamd retry count script to base BGP status on default BGP status (#3069) (3 days ago) [Saikrishna Arcot] * f4b5ef21 - Add all SKUs to the generic config update list (#3131) (3 days ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix typo "xSFP_VLOT_OFFSET"
Variables SFP_VLOT_OFFSET and QSFP_VLOT_OFFSET containing the typo are originally defined in repo sonic-platform-common. The typo has been fixed in PR #33. However, some Mellanox-specific code hasn't updated correspondingly, which results in xcvrd fail to start.
This PR updates the variable name in Mellanox-specific code correspondingly to fix that.
- How I did it
fix the typo
- How to verify it
check whether xcvrd can start normally
- Description for the changelog
[Mellanox] [Mellanox] Fix typo "xSFP_VLOT_OFFSET"
- A picture of a cute animal (not mandatory but encouraged)