[Mellanox] support get_transceiver_threshold_info #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2019 04:17
1. qsfp threshold: tx power 2. beautify code, removing some magic numbers 3. optimize get_present by only reading one byte.
stephenxs
changed the title
keboliu
approved these changes
Nov 19, 2019
|
retest this, please |
jleveque
approved these changes
Nov 19, 2019
|
@jleveque this one is requested by bmtor branch, would you please help to set the label? |
|
@yxieca just a kindly reminder: please take it to bmtor. |
lguohan
pushed a commit
that referenced
this pull request
Jan 6, 2020
* [sonic_platform.sfp] support get_transceiver_dom_threshold_info_dict * [platform/sfp]qsfp threshold and beautify code 1. qsfp threshold: tx power 2. beautify code, removing some magic numbers 3. optimize get_present by only reading one byte.
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
* [sonic_platform.sfp] support get_transceiver_dom_threshold_info_dict * [platform/sfp]qsfp threshold and beautify code 1. qsfp threshold: tx power 2. beautify code, removing some magic numbers 3. optimize get_present by only reading one byte.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
support get_transceiver_dom_threshold_info_dict
It depends on the kernel patch 0046-mlxsw-core-Extend-QSFP-EEPROM-supported-size-for-eth.patch which is not yet uploaded.
It depends on Add support for tx power threshold warning/alarm and FlatMem #66
It also depends on [submodule]advance submodule head for sonic-platform-common #3787
- How I did it
For qsfp, read and parse the 3rd page which containing the threshold info.
- How to verify it
call get_transceiver_threshold_info for SFP modules and QSFP modules with/without page 3 support.
test result:
testresult.txt
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)