Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DPB Breakout Cli Test with proper setup #3910

Merged
merged 9 commits into from
Aug 4, 2020
Merged

DPB Breakout Cli Test with proper setup #3910

merged 9 commits into from
Aug 4, 2020

Conversation

samaity
Copy link
Collaborator

@samaity samaity commented Dec 14, 2019 •
edited
Loading

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

- What I did
Created the VS setup to test DPB functionality.

  1. Created "platform.json" for vs docker.
  2. Added Test case for Breakout Cli

This PR is dependent on sonic-buildimage/pull/3909 and sonic-swss/pull/1112
and sonic-utilities/pull/766

- How to verify it


samaity@server09:~/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests$ sudo pytest -s -vv --dvsname=vs-sa breakout/test_breakout_cli.py
[sudo] password for samaity:
============================================================================================================ test session starts ============================================================================================================
platform linux2 -- Python 2.7.17, pytest-4.6.9, py-1.8.1, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/samaity/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests
plugins: repeat-0.8.0
collected 2 items

breakout/test_breakout_cli.py::TestBreakoutCli::test_InitialBreakoutMode remove extra link dummy
PASSED
breakout/test_breakout_cli.py::TestBreakoutCli::test_breakout_modes **** Breakout Cli test Starts ****
**** 1X100G --> 2x50G passed ****
**** 1X100G --> 4x25G[10G] passed ****
**** 1X100G --> 2x25G(2)+1x50G(2) passed ****
**** 1X100G --> 1x50G(2)+2x25G(2) passed ****
PASSED

This was referenced Dec 14, 2019
Merged
Closed
@samaity samaity marked this pull request as ready for review December 14, 2019 20:51
@samaity samaity force-pushed the vs_test_breakout_cli_msft branch from 1b957c5 to 3514d57 Compare March 8, 2020 01:51
@zhenggen-xu zhenggen-xu mentioned this pull request Mar 9, 2020
Merged
@zhenggen-xu zhenggen-xu requested a review from daall May 19, 2020 00:18
daall
daall previously approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need the dependencies

@lguohan
Copy link
Collaborator

lguohan commented Jun 4, 2020

retest vsimage please

@samaity
Copy link
Collaborator Author

samaity commented Jun 18, 2020

retest vsimage please

1 similar comment
@daall
Copy link
Contributor

daall commented Jun 18, 2020

retest vsimage please

@daall
Copy link
Contributor

daall commented Jun 18, 2020

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented Jun 30, 2020

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented Jun 30, 2020

retest vsimage please

@samaity
Copy link
Collaborator Author

samaity commented Jul 23, 2020

retest vs please

@samaity samaity force-pushed the vs_test_breakout_cli_msft branch 2 times, most recently from 91a9730 to 8d63e44 Compare July 23, 2020 20:13
samaity added 6 commits July 27, 2020 10:47
@samaity
DPB Breakout Cli Test with proper setup
8af8057 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Addressing review comments
730629f 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Fixed a python syntax issue
e4ca662 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
update sonic-utilities submodule
8b1b6c8 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Fixed another syntax issue
8d2908c 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
adding platform.json file capability to VS docker
dbe1d42 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity samaity force-pushed the vs_test_breakout_cli_msft branch from 226f744 to dbe1d42 Compare July 27, 2020 10:48
@samaity samaity mentioned this pull request Jul 28, 2020
Merged
samaity added 3 commits July 30, 2020 18:45
@samaity
update sonic-utilities submodule
ebf1d68 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
changed the way of testing nad fixed the input data
73d1a7e 
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Merge branch 'master' into vs_test_breakout_cli_msft
3a6853a
@samaity
Copy link
Collaborator Author

samaity commented Aug 3, 2020

retest vsimage please.

@lguohan
Copy link
Collaborator

lguohan commented Aug 3, 2020

retest vsimage please

@samaity samaity requested a review from daall August 4, 2020 04:11
@samaity
Copy link
Collaborator Author

samaity commented Aug 4, 2020

@daall can we merge this PR?

@daall daall merged commit 0a409ff into sonic-net:master Aug 4, 2020
lguohan added a commit that referenced this pull request Aug 5, 2020
@lguohan
Revert "DPB Breakout Cli Test with proper setup (#3910)"
457674c 
This reverts commit 0a409ff.
@samaity samaity mentioned this pull request Aug 8, 2020
Merged
@samaity samaity mentioned this pull request Aug 19, 2020
Merged
samaity added a commit to samaity/sonic-buildimage that referenced this pull request Aug 19, 2020
@samaity
Revert "Revert "DPB Breakout Cli Test with proper setup (sonic-net#3910…
45c24fe 
…)""

This reverts commit 457674c.
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@samaity @santhosh-kt
DPB Breakout Cli Test with proper setup (sonic-net#3910)
7f8190b 
- Created the VS setup to test DPB functionality
- Created "platform.json" for VS docker
- Added test case for Breakout CLI

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@lguohan @santhosh-kt
Revert "DPB Breakout Cli Test with proper setup (sonic-net#3910)"
1c69efc 
This reverts commit 0a409ff.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@daall daall daall approved these changes

Assignees
No one assigned
Labels
Port Breakout 🔱 Request for 202006 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samaity @lguohan @daall @qiluo-msft @jleveque