Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912

samaity · 2019-12-15T14:11:52Z

…wheel package

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

This PR is needed by sonic-platform-common PR and sonic-utilities PR.

All three PRs are necessary to run the below command.

Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]...

  Show SFP Transceiver information

Options:
  -?, -h, --help  Show this message and exit.

Commands:
  eeprom    Show interface transceiver EEPROM information
  lpmode    Show interface transceiver low-power mode status
  presence  Show interface transceiver presence

- What I did
Provide dependency of sonic-config-engine on sonic-platform-common wheel package.
- How I did it
added rules in rules/sonic-platform-common.mk
- How to verify it

samaity@a8097da3a914:/sonic$ BLDENV=stretch make -f slave.mk target/python-wheels/sonic_platform_common-1.0-py2-none-any.whl-clean
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "vs"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "admin123"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : "y"
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : "stretch"
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

samaity@a8097da3a914:/sonic$ BLDENV=stretch make -f slave.mk target/python-wheels/sonic_platform_common-1.0-py2-none-any.whl
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "vs"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "admin123"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : "y"
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : "stretch"
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

samaity@a8097da3a914:/sonic$ BLDENV=stretch make -f slave.mk target/python-wheels/sonic_platform_common-1.0-py3-none-any.whl-clean
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "vs"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "admin123"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : "y"
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : "stretch"
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

samaity@a8097da3a914:/sonic$ BLDENV=stretch make -f slave.mk target/python-wheels/sonic_platform_common-1.0-py3-none-any.whl
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "vs"
"CONFIGURED_ARCH"                 : "amd64"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS"                : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "24"
"SONIC_USE_DOCKER_BUILDKIT"       : ""
"USERNAME"                        : "admin"
"PASSWORD"                        : "admin123"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"ENABLE_PFCWD_ON_START"           : ""
"INSTALL_DEBUG_TOOLS"             : ""
"ROUTING_STACK"                   : "frr"
"FRR_USER_UID"                    : "300"
"FRR_USER_GID"                    : "300"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"
"HTTP_PROXY"                      : ""
"HTTPS_PROXY"                     : ""
"ENABLE_SYSTEM_TELEMETRY"         : "y"
"SONIC_DEBUGGING_ON"              : ""
"SONIC_PROFILING_ON"              : ""
"KERNEL_PROCURE_METHOD"           : "build"
"BUILD_TIMESTAMP"                 : ""
"BLDENV"                          : "stretch"
"VS_PREPARE_MEM"                  : "yes"
"ENABLE_SFLOW"                    : "y"

samaity@a8097da3a914:/sonic$ ls -la target/python-wheels/
total 660
drwxr-xr-x 2 samaity gsamaity   4096 Dec 15 14:00 .
drwxr-xr-x 6 samaity gsamaity   4096 Dec 12 09:22 ..
-rw-r--r-- 1 samaity gsamaity  44883 Dec 11 02:47 sonic_config_engine-1.0-py2-none-any.whl
-rw-r--r-- 1 samaity gsamaity   1853 Dec 15 14:00 sonic_config_engine-1.0-py2-none-any.whl-install.log
-rw-r--r-- 1 samaity gsamaity 171679 Dec 11 02:47 sonic_config_engine-1.0-py2-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity 128374 Nov 26 21:33 sonic_config_engine-1.0-py2-none-any.whl.log.bak
-rw-r--r-- 1 samaity gsamaity   3836 Dec 10 20:04 sonic_config_engine-1.0-py3-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity   4539 Nov  5 22:40 sonic_daemon_base-1.0-py2-none-any.whl
-rw-r--r-- 1 samaity gsamaity   1947 Nov  5 22:40 sonic_daemon_base-1.0-py2-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity 111768 Dec 15 14:00 sonic_platform_common-1.0-py2-none-any.whl
-rw-r--r-- 1 samaity gsamaity    676 Dec 15 14:00 sonic_platform_common-1.0-py2-none-any.whl-install.log
-rw-r--r-- 1 samaity gsamaity   7444 Dec 15 14:00 sonic_platform_common-1.0-py2-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity 111715 Dec 15 14:00 sonic_platform_common-1.0-py3-none-any.whl
-rw-r--r-- 1 samaity gsamaity   6176 Dec 15 14:00 sonic_platform_common-1.0-py3-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity  13712 Dec  6 08:54 swsssdk-2.0.1-py2-none-any.whl
-rw-r--r-- 1 samaity gsamaity    761 Dec 15 14:00 swsssdk-2.0.1-py2-none-any.whl-install.log
-rw-r--r-- 1 samaity gsamaity   2426 Dec  6 08:54 swsssdk-2.0.1-py2-none-any.whl.log
-rw-r--r-- 1 samaity gsamaity  13650 Dec 10 20:04 swsssdk-2.0.1-py3-none-any.whl
-rw-r--r-- 1 samaity gsamaity    779 Dec 10 20:04 swsssdk-2.0.1-py3-none-any.whl-install.log
-rw-r--r-- 1 samaity gsamaity   2290 Dec 10 20:04 swsssdk-2.0.1-py3-none-any.whl.log

…wheel package Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

rules/sonic-platform-common.mk

jleveque · 2020-01-30T20:08:09Z

Retest vsimage please

jleveque · 2020-02-07T22:37:32Z

Retest vsimage please

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [#767](#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [sonic-net#767](sonic-net#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> > This PR is dependent on [sonic-platform-common/pull/72](sonic-net/sonic-platform-common#72) All three PRs are necessary to run `show interfaces transceiver` command. 1. [sonic-net/sonic-buildimage#3912](sonic-net/sonic-buildimage#3912) 2. [sonic-net/sonic-platform-common#72](sonic-net/sonic-platform-common#72) 3. [sonic-net/sonic-utilities#767](sonic-net/sonic-utilities#767) **- What I did** Add support of platform.json in sfputil to get correct output of `show interfaces transceiver` **- How to verify it** Check whether all the below-mentioned CLI's are working correctly. ``` Usage: show interfaces transceiver [OPTIONS] COMMAND [ARGS]... Show SFP Transceiver information Options: -?, -h, --help Show this message and exit. Commands: eeprom Show interface transceiver EEPROM information lpmode Show interface transceiver low-power mode status presence Show interface transceiver presence ```

Provide dependency of sonic-config-engine on 'sonic-platform-common' …

0d07884

…wheel package Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

This was referenced Dec 15, 2019

[sfputilbase | sfputilhelper] Add support of platform.json sonic-net/sonic-platform-common#72

Merged

[sfputil] Add support of platform.json sonic-net/sonic-utilities#767

Merged

jleveque reviewed Dec 17, 2019

View reviewed changes

rules/sonic-platform-common.mk Show resolved Hide resolved

jleveque approved these changes Jan 30, 2020

View reviewed changes

zhenggen-xu mentioned this pull request Mar 9, 2020

[DPB Seastone] On boarding DPB feature to Seastone HWSKUs #4235

Merged

lguohan merged commit 0dc047c into sonic-net:master Mar 22, 2020

lguohan added the Port Breakout 🔱 label May 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912

Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912

samaity commented Dec 15, 2019 •

edited

Loading

jleveque commented Jan 30, 2020

jleveque commented Feb 7, 2020

Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912

Provide dependency of sonic-config-engine on 'sonic-platform-common' … #3912

Conversation

samaity commented Dec 15, 2019 • edited Loading

jleveque commented Jan 30, 2020

jleveque commented Feb 7, 2020

samaity commented Dec 15, 2019 •

edited

Loading