Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[docker-restapi]: Avoid building RestAPI docker by default #4018

Merged
merged 2 commits into from
Jan 15, 2020
Merged

[docker-restapi]: Avoid building RestAPI docker by default #4018

merged 2 commits into from
Jan 15, 2020

Conversation

sumukhatv
Copy link
Contributor

- What I did
Avoid building restapi docker by default
- How I did it
Added a config variable
- How to verify it
target/docker-sonic-restapi.gz will not be built
- Description for the changelog

Added ENABLE_RESTAPI config variable in rules/config

- A picture of a cute animal (not mandatory but encouraged)

@sumukhatv sumukhatv changed the title Prevent restapi docker from building by default Avoid building RestAPI docker by default Jan 13, 2020
@sumukhatv sumukhatv requested a review from prsunny January 13, 2020 22:07
@sumukhatv sumukhatv requested a review from lguohan January 14, 2020 17:29
@lguohan lguohan changed the title Avoid building RestAPI docker by default [docker-restapi]: Avoid building RestAPI docker by default Jan 14, 2020
@prsunny
Copy link
Contributor

prsunny commented Jan 14, 2020

retest vs please

@lguohan lguohan merged commit ebb07d9 into sonic-net:master Jan 15, 2020
abdosi pushed a commit that referenced this pull request Jan 21, 2020
prsunny pushed a commit that referenced this pull request Feb 5, 2020
pphuchar pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Mar 9, 2020
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants