Increasing the startsecs for teamsyncd in supervisor.conf #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the process needs to stay up before declaring the startup successfull.
jleveque
approved these changes
Jan 30, 2020
Yes, will add the labels. |
|
retest vsimage please |
yxieca
pushed a commit
that referenced
this pull request
Jan 30, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
rlhui
pushed a commit
that referenced
this pull request
Jan 31, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Updating the startsecs=5sec for teamsyncd to make the time for which the process needs to stay up before declaring the startup successfull.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updating the startsecs=5sec for teamsyncd to make the time for which …the process needs to stay up before declaring the startup successful.
- How I did it
Added the statement startsecs=5sec for teamsyncd process in supervisor.conf file in teamd docker.
- How to verify it
Back to back config reloads was tried.
- Description for the changelog
As per the current implementation in teamsyncd, When a TeamPortSync object is created, if there is a failure in team_init/team_alloc, it is retried 3 times with a sleep of 1 sec in between. So the teamsyncd could take upto 3 secs for coming up in case it hits the error. Hence increasing the startsecs to 5sec, so that supervisord will recognize the failure of teamsyncd and try starting again.
- A picture of a cute animal (not mandatory but encouraged)