[mgmt-framework] start after syncd #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every service starts after syncd to start the most critical parts first Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
| @@ -1,7 +1,7 @@ | |||
| [Unit] | |||
| Description=Management Framework container | |||
| Requires=swss.service | |||
| After=swss.service | |||
| After=swss.service syncd.service | |||
There was a problem hiding this comment.
Can it be just "After syncd.service" as syncd is after swss ?
There was a problem hiding this comment.
Technically, yes, but it can't hurt to be more explicit.
jleveque
approved these changes
Feb 20, 2020
|
Requesting to add this to 201911 |
abdosi
pushed a commit
that referenced
this pull request
Feb 24, 2020
every service starts after syncd to start the most critical parts first Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Feb 26, 2020
every service starts after syncd to start the most critical parts first Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
every service starts after syncd to start the most critical parts first Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
every service starts after syncd to start the most critical parts first Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
every service starts after syncd to start the most critical parts first
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)