[baseimage]: Install Kubernetes packages if enabled in image #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you provide description of this pr, what are you trying to achieve in this pr? |
lguohan
reviewed
Apr 5, 2020
lguohan
reviewed
Apr 5, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
qiluo-msft
reviewed
Apr 6, 2020
Built a private image to test to work fine.
qiluo-msft
reviewed
Apr 8, 2020
qiluo-msft
reviewed
Apr 8, 2020
qiluo-msft
reviewed
Apr 8, 2020
Make a fix, as kubeadm no demands a higher version of kubelet & kubectl. As kubeadm auto install kubectl & kubelet, removing explicit install is an easier/robust fix.
1) Dropped helper & pod scripts 2) Made install verbose
qiluo-msft
approved these changes
Apr 10, 2020
renukamanavalan
changed the title
lguohan
approved these changes
Apr 10, 2020
lguohan
changed the title
|
retest vs please. |
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
renukamanavalan
added
Included in 201911 Branch
Request for 201911 Branch 
Enhancement ➕
and removed
Included in 201911 Branch
labels
|
@renukamanavalan There is conflict in cherry-pick. Please create PR for 201911 |
renukamanavalan
added a commit
to renukamanavalan/sonic-buildimage
that referenced
this pull request
Apr 16, 2020
…et#4374) * Install kubernetes worker node packages, if enabled.
|
Created PR #4432 for 201911 branch. |
lguohan
pushed a commit
that referenced
this pull request
Apr 17, 2020
…4432) Install kubeadm, which transparently installs kubelet & kubectl As well download required Kubernetes images required to run as kubernetes node. The kubelet service is intentionally kept in disabled state, as it would otherwise continuously restart wasting resources, until join to master.
|
#4432 is merged. |
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…et#4374) (sonic-net#4432) Install kubeadm, which transparently installs kubelet & kubectl As well download required Kubernetes images required to run as kubernetes node. The kubelet service is intentionally kept in disabled state, as it would otherwise continuously restart wasting resources, until join to master.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Goal: To be able to join a kubernetes cluster w/o requiring any more packages/images.