Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Juniper QFX5210] Fix Python errors #4394

Merged
merged 2 commits into from
Apr 9, 2020
Merged

[Juniper QFX5210] Fix Python errors #4394

merged 2 commits into from
Apr 9, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Apr 8, 2020 •
edited
Loading

  • __init__ method cannot return a value
  • Also remove unnecessary 'pass' statement

@jleveque jleveque requested a review from lguohan April 8, 2020 04:06
@jleveque jleveque self-assigned this Apr 8, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 8, 2020

This pull request fixes 3 alerts when merging b93a3df into de5a04a - view on LGTM.com

fixed alerts:

  • 2 for __init__ method returns a value
  • 1 for Unnecessary pass

@lguohan
Copy link
Collaborator

lguohan commented Apr 8, 2020

retest broadcom please

@lguohan
Copy link
Collaborator

lguohan commented Apr 8, 2020

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Apr 8, 2020

retest vs please

@jleveque
Copy link
Contributor Author

jleveque commented Apr 9, 2020

Retest vsimage please

@lguohan lguohan merged commit 9068652 into sonic-net:master Apr 9, 2020
@jleveque jleveque deleted the fix_python_warning_juniper_qfx5210 branch April 9, 2020 17:55
@abdosi
Copy link
Contributor

abdosi commented Apr 11, 2020

@jleveque seeing conflict in cherry-pick for 201911. Please Create PR

@jleveque jleveque mentioned this pull request Apr 11, 2020
Merged
@jleveque
Copy link
Contributor Author

@abdosi: Thanks for the heads-up. Done: #4413

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Bug 🐛 Platform: Juniper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @lguohan @abdosi