[baseos] Avoid disconnecting mgmt when re-cfg interfaces #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Apr 29, 2017
| NEW_MGMT_MASK=`sonic-cfggen -m /etc/sonic/minigraph.xml -v 'minigraph_mgmt_interface["mask"]'` | ||
|
|
||
| ifconfig eth0 $NEW_MGMT_IP netmask $NEW_MGMT_MASK | ||
|
|
There was a problem hiding this comment.
so we only have lo and eth0 at this moment?
|
can you add description why we need to avoid disconnecting mgmt when re-cfg interfaces? |
lguohan
requested changes
May 1, 2017
|
Added description. |
stcheng
reviewed
Jun 2, 2017
| NEW_MGMT_MASK=`sonic-cfggen -m /etc/sonic/minigraph.xml -v 'minigraph_mgmt_interface["mask"]'` | ||
|
|
||
| ifconfig eth0 $NEW_MGMT_IP netmask $NEW_MGMT_MASK | ||
| [ -f /var/run/dhclient.eth0.pid ] && kill `cat /var/run/dhclient.eth0.pid` && rm -f /var/run/dhclient.eth0.pid |
lguohan
approved these changes
Jun 7, 2017
lguohan
pushed a commit
that referenced
this pull request
Jan 29, 2020
567191f [sairedis] Add knob to disable recording statistics API calls (#547) 8513506 Create Switch and SwitchContainer classes (#549) … e991281 Update .gitignore (#551) 84b0eed [sairedis] Skip recording GET operations on AVAILABLE attributes (#550) … 634e4e3 [meta] Return OBJECT_IN_USE when removing port is in use (#553) 2961bd3 [syncd] Fix rpc server flag condition (#557)
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…sonic-net#553) * Add basic schema for warm start schema in configDB and application DB. Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com> * Move warm start table for process stats to state DB Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com> * Add reconciliation timer entry in configDB warm restart table. Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com> * Update warm restart timer schema Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com> * There might be more than one timer at system level or individual docker Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jan 31, 2025
[202412] Code sync sonic-net/sonic-buildimage:202411 => 202412
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of interfaces-config, we restarted network service after re-generate interfaces file based on minigraph. This might break ssh connection through mgmt port even though mgmt ip was not changed.
To address this, we are now calling ifdown/ifup on only interfaces other than eth0, and config eth0 address seperately.