Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DPB] [Mellanox] added capability files for SN2100 platform #6016

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 24, 2020

- Why I did it

platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout

- How I did it

Created capability files according to platform specification SN2100

- How to verify it

Full qualification requires bugs fixes reported under sonic-buildimage

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you missing 50G? i can do split to 2 and still have 50G.
in the default and for non split, why not other speeds are allowed and only 100g and 40g?

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Contributor Author

are you missing 50G? i can do split to 2 and still have 50G.
in the default and for non split, why not other speeds are allowed and only 100g and 40g?

About allowed speed: I took as an example [DPB Seastone] On boarding DPB feature to Seastone HWSKUs PR.
Why there is only 100G and 40G allowed - because I suppose that all available lanes should be on. If the port has 4 lanes each lane 25G, and if all 4 lanes will be on, only 2 variants have a sense (100G = 25G + 25G + 25G + 25G) and (40G = 10G + 10G + 10G + 10G)

@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as draft December 18, 2020 15:53
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Contributor Author

Please don't merge this PR until [DPB][MLNX][YANG-models] extended regex pattern according to MLNX systems speeds requirements PR will be merged

@vadymhlushko-mlnx
Copy link
Contributor Author

retest vs please

@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as ready for review December 23, 2020 12:57
@liat-grozovik liat-grozovik changed the title [DPB] added capability files for SN2100 platform [DPB] [Mellanox] added capability files for SN2100 platform Jan 13, 2021
@liat-grozovik liat-grozovik merged commit ffc957c into sonic-net:master Jan 17, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the sn2100_dpb_capability_files branch January 25, 2021 08:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants