Source interface support for NTP

[PrabhuSreenivasan]

Signed-off-by: Prabhu Sreenivasan prabhu.sreenivasan@broadcom

- Why I did it
Added source interface support for NTP.
Also made NTP start on Mgmt-VRF by default when configured.

- How I did it

1. Updated hostcfg to listen to global config NTP and NTP_SERVER tables and restart ntp when ever the configuration changes. NTP table includes source interface configuration.
2. The ntp script updated to by default start on Mgmt-VFT when configured.

- How to verify it
Existing ntp pytest.

- Which release branch to backport (provide reason below if selected)

- Description for the changelog
Source interface support and handle config change without unnecessary restart of ntp-config ntp service.
NTP start on Mgmt-VRF by default when configured

[lguohan]

@PrabhuSreenivasan, can you check the build failure?

[PrabhuSreenivasan]

@PrabhuSreenivasan, can you check the build failure?

@lguohan, Fixed the build failure.

[PrabhuSreenivasan]

@lguohan, As per your suggestion, I have moved the ntp service ordering to a new PR #6115

[lguohan]

#pr 6115 is merged. can you rebase this pr? I will approve.

[PrabhuSreenivasan]

#pr 6115 is merged. can you rebase this pr? I will approve.

I have rebased this PR. Thanks.

[PrabhuSreenivasan]

retest this please

[PrabhuSreenivasan]

One of the vsimage test failed due to 'hosts': 'vlab-01' not reachable.

15:27:03 =========================== short test summary info ============================
15:27:03 FAILED ntp/test_ntp.py::test_ntp - AnsibleConnectionFailure: Host unreachable

[lguohan]

retest this please

[lguohan]

not familiar with the error, since your change is related to ntp, so it would be regression introduced in this pr. let me retest,

[lguohan]

@PrabhuSreenivasan looks like the test is consistently failing, can you check why the test is failing? we are unable to merge this pr until the test is passing.

[lguohan]

seems ntp test still failing?

[PrabhuSreenivasan]

retest vs please

[PrabhuSreenivasan]

retest vsimage please

[PrabhuSreenivasan]

seems ntp test still failing?

Failing due to python2 to python3 change. working on a fix.

root@sonic:/home/admin# sonic-cfggen -d -t /usr/share/sonic/templates/ntp.conf.j2 >/etc/ntp.conf
Traceback (most recent call last):
File "/usr/local/bin/sonic-cfggen", line 433, in
main()
File "/usr/local/bin/sonic-cfggen", line 398, in main
template_data = template.render(data)
File "/usr/local/lib/python3.7/dist-packages/jinja2/environment.py", line 1090, in render
self.environment.handle_exception()
File "/usr/local/lib/python3.7/dist-packages/jinja2/environment.py", line 832, in handle_exception
reraise(*rewrite_traceback_stack(source=source))
File "/usr/local/lib/python3.7/dist-packages/jinja2/_compat.py", line 28, in reraise
raise value.with_traceback(tb)
File "/usr/share/sonic/templates/ntp.conf.j2", line 53, in top-level template code
{% set ns = namespace(source_intf) %}
File "/usr/local/lib/python3.7/dist-packages/jinja2/utils.py", line 697, in init
self.__attrs = dict(*args, **kwargs)
jinja2.exceptions.UndefinedError: 'source_intf' is undefined

[PrabhuSreenivasan]

retest vsimage please

[PrabhuSreenivasan]

All NTP tests are passing. New failure "tacacs/test_rw_user.py::test_rw_user FAILED" seems quite unrelated, but consistently failing.

[PrabhuSreenivasan]

retest vsimage please

[ben-gale]

@lguohan - we seem to be stuck on the same failing test, which does not seem to be related to this change. Can you help (e.g. fix or skip)? We need to get this merged ....

[lguohan]

retest vsimage please

[lguohan]

retest vsimage please

[lguohan]

retest vsimage please

[lguohan]

thanks for your contribution!