Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[sonic-sairedis submodule] Updated SAI header 1.7.1 for BRCM and Mellanox SDK/SAI #6218

Merged
merged 8 commits into from
Dec 20, 2020
Merged

[sonic-sairedis submodule] Updated SAI header 1.7.1 for BRCM and Mellanox SDK/SAI #6218

merged 8 commits into from
Dec 20, 2020

Conversation

vmittal-msft
Copy link
Contributor

@vmittal-msft vmittal-msft commented Dec 15, 2020

- Why I did it
To update SAI header to tag 1.7.1

- How I did it

  1. Updated sonic-sairedis to point to new SAI 1.7.1 header
  2. Updated MLNX SAI/SDK supporting new header
  3. Updated BRCM debians supporting new header

- How to verify it
Installed sonic image on DUT to verify -

  1. ports
  2. interfaces
  3. IP routes
  4. BGP neighbors
  5. ping working for BGP neighbors

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

Updated sonic-sairedis to point to SAI 1.7.1
sonic-net/sonic-sairedis@d814d2c...560c171

- A picture of a cute animal (not mandatory but encouraged)

@vmittal-msft
Copy link
Contributor Author

This PR is in draft mode. It is awaiting sonic-sairedis to be merged (sonic-net/sonic-sairedis#748) so compilation may not go thru till then.

@liat-grozovik
Copy link
Collaborator

few general comments

  • PR subject is not aligned with the changes. It is not just submodule update but rather Mellanox SDK/SAI update as well.
  • Please add list of submodule fixes while introducing submodule to buildimage

The Mellanox SDK/FW and SAI components are correct :-)

@vmittal-msft vmittal-msft changed the title [sonic-sairedis submodule] Update SAI to 1.7.1 [sonic-sairedis submodule] Updated SAI header 1.7.1 and Mellanox SDK/SAI Dec 18, 2020
@vmittal-msft vmittal-msft marked this pull request as ready for review December 18, 2020 21:04
@vmittal-msft vmittal-msft changed the title [sonic-sairedis submodule] Updated SAI header 1.7.1 and Mellanox SDK/SAI [sonic-sairedis submodule] Updated SAI header 1.7.1 for BRCM and Mellanox SDK/SAI Dec 18, 2020
@vmittal-msft
Copy link
Contributor Author

retest vsimage please

smaheshm
smaheshm previously approved these changes Dec 18, 2020
Copy link
Contributor

@smaheshm smaheshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please wait for all test results to pass. :shipit:

@vmittal-msft
Copy link
Contributor Author

retest vsimage please

@vmittal-msft
Copy link
Contributor Author

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Dec 19, 2020

can you resolve conflict?

@vmittal-msft
Copy link
Contributor Author

retest vs please

@vmittal-msft
Copy link
Contributor Author

retest vsimage please

@vmittal-msft
Copy link
Contributor Author

retest this please

@vmittal-msft vmittal-msft merged commit ee8c3d3 into sonic-net:master Dec 20, 2020
@vmittal-msft vmittal-msft deleted the sonic-sai1.7.1 branch December 20, 2020 20:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants