Add ENABLE_SYNCD_RPC option #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marian-pritsak, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
lguohan
reviewed
May 30, 2017
platform/broadcom/one-aboot.mk
Outdated
| @@ -1,6 +1,6 @@ | |||
| # sonic broadcom one image installer | |||
|
|
|||
| SONIC_ONE_ABOOT_IMAGE = sonic-aboot-broadcom.swi | |||
| SONIC_ONE_ABOOT_IMAGE = sonic-aboot-broadcom$(if $(ENABLE_SYNCD_RPC),-rpc).swi | |||
There was a problem hiding this comment.
for simplicity, I suggest leave appending -rpc to the user. The build system still builds the same file. sonic-aboot-broadcom.swi, user will then rename the file properly.
lguohan
reviewed
May 30, 2017
Under rules/config now there's additional configuration option ENABLE_SYNCD_RPC that allows building SONIC installer with docker-syncd-*-rpc for evaluation purposes. Signed-off-by: marian-pritsak <marianp@mellanox.com>
marian-pritsak
changed the title
lguohan
approved these changes
May 30, 2017
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Nov 6, 2019
[warm/fast reboot] continue executing when killing docker failed (sonic-net#713) [Ying Xie] [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules(sonic-net#714)[Shuotian Cheng] [config]: Flush the neighbor table when removing the router interface(sonic-net#606) [Shuotian Cheng] Add a generic configlet application script (sonic-net#716) [Renuka Manavalan] Management vrf snmp cli support (sonic-net#472) [Harish Venkatraman] show subinterfaces status (sonic-net#642) [Wenda Ni] sonic-utilities: Add support for sFlow (sonic-net#592) [Garrick He]
lguohan
pushed a commit
that referenced
this pull request
Nov 6, 2019
- [warm/fast reboot] continue executing when killing docker failed (#713) [Ying Xie] - [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules(#714)[Shuotian Cheng] - [config]: Flush the neighbor table when removing the router interface(#606) [Shuotian Cheng] - Add a generic configlet application script (#716) [Renuka Manavalan] - Management vrf snmp cli support (#472) [Harish Venkatraman] - show subinterfaces status (#642) [Wenda Ni] - sonic-utilities: Add support for sFlow (#592) [Garrick He]
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
- [warm/fast reboot] continue executing when killing docker failed (sonic-net#713) [Ying Xie] - [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules(sonic-net#714)[Shuotian Cheng] - [config]: Flush the neighbor table when removing the router interface(sonic-net#606) [Shuotian Cheng] - Add a generic configlet application script (sonic-net#716) [Renuka Manavalan] - Management vrf snmp cli support (sonic-net#472) [Harish Venkatraman] - show subinterfaces status (sonic-net#642) [Wenda Ni] - sonic-utilities: Add support for sFlow (sonic-net#592) [Garrick He]
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
* Add sub port interface to intfutil status Signed-off-by: Wenda Ni <wenni@microsoft.com> * Format change Signed-off-by: Wenda Ni <wenni@microsoft.com> * Hook 'intfutil status' with show subinterfaces status Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add 'intfutil status subport' to show only the status of sub port interfaces Signed-off-by: Wenda Ni <wenni@microsoft.com> * Hook 'intfutil status subport' with 'show subinterfaces status' Signed-off-by: Wenda Ni <wenni@microsoft.com> * Support intfutil status <sub_port_intf_name> Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add alias naming mode support Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comment: concatenate command line, and validate input Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comment: keep show interface status intact Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for show interfaces status / intfutil status Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for 'show interfaces status --verbose' Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for 'show subinterfaces status' / 'intfutil status subport' Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for 'show subinterfaces status --verbose' Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for single sub interface status show Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for '--verbose' single sub interface status show Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for showing status of single sub interface in alias naming mode Signed-off-by: Wenda Ni <wenni@microsoft.com> * Add unit test for '--verbose' status of single sub interface in alias naming mode Signed-off-by: Wenda Ni <wenni@microsoft.com>
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
) * [player] Add more log info when fail response * [syncd] Send notify view response even when exception happen * [vs] Add resource limiter * [vs] Start using resource limiter * [syncd] Fix vendor sai functions names check * [syncd] Add apply view remove object sanity checks * [syncd] Lower NPU switch log to notice * [syncd] Add simlar best match candidate with most same attributes * [syncd] Add BreakConfig class * [syncd] Add break config option to command line * [syncd] Add comparison logic break before make path * [syncd] Add break config parser * [syncd] Add break config size method * [syncd] Fix command line parser help message * [syncd] Start using break config parser * Update aspell * [tests] Add unittests
stepanblyschak
added a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jul 6, 2022
``` 8bce8f6 [202111] [select] break the select loop if interrupt_on_signal flag is set (sonic-net#624) (sonic-net#642) ``` Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Feb 27, 2025
… automatically (sonic-net#642) #### Why I did it src/sonic-platform-common ``` * 7a5807f - (HEAD -> 202405, origin/202405) [cmis] Optimize cmis.get_error_description speed for passive module (sonic-net#541) (sonic-net#29) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under rules/config now there's additional configuration option
ENABLE_SYNCD_RPC that allows building SONIC installer with
docker-syncd-*-rpc for evaluation purposes.
Signed-off-by: marian-pritsak marianp@mellanox.com