Anchor "libprotobuf-dev" version to a specific version by using debian control file dependency #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debian control dependency
gechiang
requested review from
lguohan,
rlhui,
yxieca,
vmittal-msft and
smaheshm
lguohan
approved these changes
Jan 12, 2021
|
@lguohan Should I be concerned about the "Azure.sonic-buildimage (Test kvmtest)" and "Azure.sonic-buildimage" both failed? |
|
it is ok, I sent email on this subject. |
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
…debian control dependency (#6420)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
From time to time the BRCM SAI debian built may be using one version of libprotobuf-dev while a different version being picked during installation. This causes the installation failure. We should anchor to a specific version during SAI debian build via the debian control file dependency specification to eliminate this type of failures.
- How I did it
Change the SAI debian control file to specify a specific dependency version:
Depends: libprotobuf-dev, libprotobuf-lite17, libprotobuf17
Remove the use of "sudo apt install -y libprotobuf-dev" at build script.
- How to verify it
Incorporate this new SAI debian on a private sonic-buildimage and build for BRCM binary and installed to a BRCM SKU DUT to validate the entire process did not encounter any issue and that DUT boots up fine as previous version.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Anchor "libprotobuf-dev" version to a specific version by using debian control file dependency