TSA/B/C changes for multi-asic #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
reviewed
Jan 21, 2021
In addition skip enforcing it on route maps used between internal BGP sessions.
|
Updated the description with traffic/route prefix tests with TSA, B, C commands. |
|
retest this please |
|
have you check the sonic-mgmt test bgp/test_traffic_shift.py? |
… ASIC admin@str--acs-1:~$ sudo /usr/bin/TSA System Mode: Normal -> Maintenance and in case of Multi-ASIC admin@str--acs-1:~$ sudo /usr/bin/TSA BGP0 : System Mode: Normal -> Maintenance BGP1 : System Mode: Normal -> Maintenance BGP2 : System Mode: Normal -> Maintenance
abdosi
reviewed
Feb 8, 2021
The test bgp/test_traffic_shift.py is passing for single ASIC. I will wait for the new run to complete. |
abdosi
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
LGTM.
@judyjoseph One note FYI i have open PR : sonic-net/sonic-mgmt#2977 where code has got moved around . This will impact multi-asic change going forward.
lguohan
approved these changes
Feb 12, 2021
abdosi
pushed a commit
that referenced
this pull request
Feb 19, 2021
- Introduced TS common file in docker as well and moved common functions.
- TSA/B/C scripts run only in BGP instances for front end ASICs.
In addition skip enforcing it on route maps used between internal BGP sessions.
admin@str--acs-1:~$ sudo /usr/bin/TSA
System Mode: Normal -> Maintenance
and in case of Multi-ASIC
admin@str--acs-1:~$ sudo /usr/bin/TSA
BGP0 : System Mode: Normal -> Maintenance
BGP1 : System Mode: Normal -> Maintenance
BGP2 : System Mode: Normal -> Maintenance
lguohan
pushed a commit
to lguohan/sonic-buildimage
that referenced
this pull request
May 3, 2021
- Introduced TS common file in docker as well and moved common functions.
- TSA/B/C scripts run only in BGP instances for front end ASICs.
In addition skip enforcing it on route maps used between internal BGP sessions.
admin@str--acs-1:~$ sudo /usr/bin/TSA
System Mode: Normal -> Maintenance
and in case of Multi-ASIC
admin@str--acs-1:~$ sudo /usr/bin/TSA
BGP0 : System Mode: Normal -> Maintenance
BGP1 : System Mode: Normal -> Maintenance
BGP2 : System Mode: Normal -> Maintenance
daall
pushed a commit
that referenced
this pull request
May 3, 2021
- Introduced TS common file in docker as well and moved common functions.
- TSA/B/C scripts run only in BGP instances for front end ASICs.
In addition skip enforcing it on route maps used between internal BGP sessions.
admin@str--acs-1:~$ sudo /usr/bin/TSA
System Mode: Normal -> Maintenance
and in case of Multi-ASIC
admin@str--acs-1:~$ sudo /usr/bin/TSA
BGP0 : System Mode: Normal -> Maintenance
BGP1 : System Mode: Normal -> Maintenance
BGP2 : System Mode: Normal -> Maintenance
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Changes to TSA, TSB, TSC scripts to support multiple BGP instances in multi-asic platforms.
- How I did it
Enhance the script to replicate the isolate/unisolate actions in each of the BGP dockers.
- How to verify it
On Single ASIC, before this change
On Single ASIC, after this change
on multi-asic
Traffic test and prefixes received on the connected Arista VM running as a T2. Also I am doing a ping to show the traffic comming in and stopping when we issue TSA command.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)