Fix docker-sonic-mgmt reproducible related issue. #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushilongbuaa
added
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.docker-sonic-mgmt |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xumia
reviewed
Dec 29, 2021
| @@ -72,7 +72,7 @@ set_reproducible_mirrors() | |||
|
|
|||
| local mirrors="/etc/apt/sources.list $(find /etc/apt/sources.list.d/ -type f)" | |||
| for mirror in $mirrors; do | |||
| sed -i "$expression" "$mirror" | |||
| sed -i "$expression" "$mirror" || sudo sed -i "$expression" "$mirror" | |||
There was a problem hiding this comment.
Can we change to run the command as root in docker-sonic-mgmt?
There was a problem hiding this comment.
how about now?
liushilongbuaa
force-pushed
the
fix-sed
branch
from
ae025ef to
210a23c
Compare
liushilongbuaa
force-pushed
the
fix-sed
branch
from
210a23c to
a5f665d
Compare
xumia
approved these changes
Jan 5, 2022
xumia
reviewed
Jan 5, 2022
| SUDO=sudo | ||
| else | ||
| SUDO='' | ||
| fi |
There was a problem hiding this comment.
Can be simplified to
[
|
@liushilongbuaa , we should not need to merge to release branches, right? |
liushilongbuaa
removed
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
xumia
pushed a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 11, 2022
Reproducible build script breaks docker-sonic-mgmt build.
xumia
added
Request for 202111 Branch
6 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 21, 2022
Reproducible build script breaks docker-sonic-mgmt build.
judyjoseph
pushed a commit
that referenced
this pull request
Apr 25, 2022
Reproducible build script breaks docker-sonic-mgmt build.
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2022
Reproducible build script breaks docker-sonic-mgmt build.
6 tasks
liushilongbuaa
added a commit
that referenced
this pull request
May 11, 2022
Reproducible build script breaks docker-sonic-mgmt build.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
when using 'sed -i' the directory must also be writable as sed will create a temporary file in that directory first.
This issue breaks building sonic-mgmt docker image.
we should use sudo to resolve this issue, but sonic-base image haven't installed sudo tool.
So we should use both 'sed -i' and 'sudo sed -i'
How I did it
add retry with sudo.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)