-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clear counter when dhcp6relay init #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @yxieca could you please help to review this PR? |
9368652
to
a82d4b6
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Dec 12, 2024
Hi @bingwang-ms could you please help to approve the backport request? |
mssonicbld
pushed a commit
to mssonicbld/sonic-dhcp-relay
that referenced
this pull request
Dec 16, 2024
Why I did it When dhcp6relay startup, it would clear and reset the counter in DHCP_RELAY table, and it would cause that counter data of deleted Vlan wouldn't be clear. How I did it Clear all counter when dhcp6relay init How I verify it UT Install new dhcp6relay in testbed
Cherry-pick PR to 202405: #54 |
yxieca
pushed a commit
that referenced
this pull request
Dec 18, 2024
Why I did it When dhcp6relay startup, it would clear and reset the counter in DHCP_RELAY table, and it would cause that counter data of deleted Vlan wouldn't be clear. How I did it Clear all counter when dhcp6relay init How I verify it UT Install new dhcp6relay in testbed Co-authored-by: Yaqiang Zhu <zyq1512099831@gmail.com>
yaqiangz
added a commit
to yaqiangz/sonic-dhcp-relay
that referenced
this pull request
Jan 6, 2025
Why I did it When dhcp6relay startup, it would clear and reset the counter in DHCP_RELAY table, and it would cause that counter data of deleted Vlan wouldn't be clear. How I did it Clear all counter when dhcp6relay init How I verify it UT Install new dhcp6relay in testbed
mssonicbld
pushed a commit
to mssonicbld/sonic-dhcp-relay
that referenced
this pull request
Jan 6, 2025
Why I did it When dhcp6relay startup, it would clear and reset the counter in DHCP_RELAY table, and it would cause that counter data of deleted Vlan wouldn't be clear. How I did it Clear all counter when dhcp6relay init How I verify it UT Install new dhcp6relay in testbed
Cherry-pick PR to 202411: #65 |
kperumalbfn
pushed a commit
that referenced
this pull request
Jan 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue sonic-net/sonic-buildimage#15047
Why I did it
When dhcp6relay startup, it would clear and reset the counter in
DHCP_RELAY
table, and it would cause that counter data of deleted Vlan wouldn't be clear.How I did it
Clear all counter when dhcp6relay init
How I verify it
2.1. Add Vlan2000,
2.2. Send dhcpv6 packets to Vlan2000, confirm that counter has been updated
2.3 reload config without Vlan2000, confirm that counter data of Vlan2000 has been deleted