-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Mellanox] Backport patch to remove critical trip point from thermal zones #201
Conversation
Thank you for the patch.
|
This is a work in progress in term of linux main. Our team will do the upstream process soon but this must not delay this update. The reason for that that this is a real production issue and we cannot wait for this one. As for the information you are looking for, it is all in the patch itself. " According to the system requirements software should never perform In both cases, when critical temperature is reached, system will be This is relevant to only Mellanox switches as the main protection is done by Firmware. |
The commit in this merge/pull request still has the typos and a to-be-desired commit message. It’s rude to expect from reviewers and later people looking through commits to look at the diff to find out what is done. If this is important to you, then I suggest you make sure, that all the formal requirements for patches are met. For upstream, if it’s done later, please add a comment to the commit message, that it is going to be upstreamed soon. |
…zones 1. 0027-mlxsw-core-Remove-critical-trip-point-from-thermal-z.patch Disable software thermal protection by removing critical trip points for the all thermal zones. According to the system requirements software should never perform system thermal protection, since all the systems implement two levels of thermal protection: the first one is performed by firmware, the second, in case firmware was not able to perform protection, by hardware, while the temperature threshold for hardware protection is higher than for firmware. In both cases, when critical temperature is reached, system will be shutdown. Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
696a974
to
ab7d820
Compare
Hi @paulmenzel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Mellanox devices” is a little broad, but maybe you have a QA system, which tests the SONiC buidls on all devices.
Hi paulmenzel |
@paulmenzel - Can you please merge this PR ? |
I would, if I could, but I do not have the permission to merge the requests. At least @lguohan has the permissions. |
@lguohan - Can you please merge this PR ? and also add the tag that is required for 202012 ? Thanks. |
…zones (#201) 1. 0027-mlxsw-core-Remove-critical-trip-point-from-thermal-z.patch Disable software thermal protection by removing critical trip points for the all thermal zones. According to the system requirements software should never perform system thermal protection, since all the systems implement two levels of thermal protection: the first one is performed by firmware, the second, in case firmware was not able to perform protection, by hardware, while the temperature threshold for hardware protection is higher than for firmware. In both cases, when critical temperature is reached, system will be shutdown. Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> It has been verified on Mellanox devices Signed-off-by: Stephen Sun <stephens@nvidia.com>
Backport a patch to remove critical trip point from thermal zones for Mellanox devices
It has been verified on Mellanox devices
Signed-off-by: Stephen Sun stephens@nvidia.com