Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove kernel config SERIAL_8250_RUNTIME_UARTS #286

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

madhava28
Copy link
Contributor

Issue:
UART parameter of Cisco linux kernel configuration will cause Accton platform
not to dump any message on booting stage.

Fix:
Remove SERIAL_8250_RUNTIME_UARTS config. This will be passed as bootargs to the
kernel during bootup.

Signed-off-by: Madhava Reddy Siddareddygari msiddare@cisco.com

Issue:
UART parameter of Cisco linux kernel configuration will cause Accton platform
not to dump any message on booting stage.

Fix:
Remove SERIAL_8250_RUNTIME_UARTS config. This will be passed as bootargs to the
kernel during bootup.

Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com>
@paulmenzel
Copy link
Contributor

Please elaborate the problem. What Accton platform fails to boot, and what is the reason.

What is now happening with the Cisco devices? Will they still work? Why was the value set to 32 in the first place?

Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating GitHub meta data.

@lguohan
Copy link
Contributor

lguohan commented Jul 21, 2022

here is the issue. sonic-net/sonic-buildimage#11238

the plan is that cisco will revert this one, and then use kernel bootargs to set it up only for cisco platforms.

not sure why it breaks on accton platforms.

Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please amend the commit message with a summary of the issue in the commit message, add document Linux CLI parameter name.

@saiarcot895 saiarcot895 merged commit fbb76cc into sonic-net:202012 Jul 28, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-linux-kernel submodule pointer to include the following:
* Remove kernel config SERIAL_8250_RUNTIME_UARTS ([sonic-net#286](sonic-net/sonic-linux-kernel#286))

Signed-off-by: dprital <drorp@nvidia.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants