[ansible]: upgrade to use ansible 2.8.7 #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove docker-py 1.7.2 - remove library/docker.py - use docker-login and docker-container module from ansible - adapt to docker 4.0.2 in vm_topology.py requires ansible 2.8.7
Signed-off-by: Guohan Lu <gulv@microsoft.com>
to_unicode is deprecated and removed starting ansible 2.5
Signed-off-by: Guohan Lu <gulv@microsoft.com>
use listen for "Update VM state" You cannot notify a handler that is defined inside of an include. Signed-off-by: Guohan Lu <gulv@microsoft.com>
ansible changes Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
I am not able to verify every test. Here are things I verified.
depends on sonic-net/sonic-buildimage#3776
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation