-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[t0 t1 test merge] migrate ECN multidiut #16866
Open
auspham
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
auspham:austinpham/31217327-merge-multidut-ecn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[t0 t1 test merge] migrate ECN multidiut #16866
auspham
wants to merge
1
commit into
sonic-net:master
from
auspham:austinpham/31217327-merge-multidut-ecn
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ffd7fba
to
f1dfbc7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
f1dfbc7
to
cb84bde
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
Feb 10, 2025
cb84bde
to
002097c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
T0 test result: MSFT access only |
002097c
to
70f5af7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
commented
Feb 13, 2025
tests/conftest.py
Outdated
executor.submit(config_reload, duthost, wait_before_force_reload=300, safe_reload=True, | ||
check_intf_up_ports=True, wait_for_bgp=True) | ||
check_intf_up_ports=True, wait_for_bgp=wait_for_bgp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In here we dont want to wait_for_bgp if we specified that we skip sanity.
MSFT only tests: https://elastictest.org/scheduler/testplan/67ad53046f7ee067ea75ff08 I also find that the failure cases also fail in legacy code. |
sdszhang
reviewed
Feb 13, 2025
Signed-off-by: Austin Pham <austinpham@microsoft.com>
70f5af7
to
dbe7cfe
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: migrate multidut ecn to ecn folder snappi tests
Fixes # (issue) 31217327
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation