Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

multi-asic support for test_cacl_application.py #3070

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Mar 2, 2021

What/Why I did:

  • Enhanced test_cacl_application.py for multi-asic platforms. Also it adds new test case to cover all multi-asic specific changes
    as done in PR's:-

sonic-net/sonic-buildimage#5022
sonic-net/sonic-buildimage#5420
sonic-net/sonic-buildimage#5364
sonic-net/sonic-buildimage#6765

  • Also fix some of API in common/devices.py and bug in config_facts

How I did:-
Added new test case for multi-asic platforms to run on all front-asic's.

How I verify:

Verified both on single and multi-asic platfroms.

@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2021

This pull request introduces 2 alerts when merging ed356c1 into bec8443 - view on LGTM.com

new alerts:

  • 2 for Suspicious unused loop iteration variable

@jleveque
Copy link
Contributor

jleveque commented Mar 2, 2021

Is there a way to fix the LGTM alerts?

Yes, Fixed.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi merged commit b38562a into sonic-net:master Mar 2, 2021
@abdosi abdosi deleted the cacl branch March 2, 2021 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants