Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ test_autonegotiation ] Added missing topology mark #3780

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

SavchukRomanLv
Copy link
Contributor

Signed-off-by: Roman Savchuk romanx.savchuk@intel.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

TC skipped when run with --topology mark
is skipped when no topology marker is given

How did you do it?

Run TC with --topology=any, TC was not skipped

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@SavchukRomanLv SavchukRomanLv requested a review from jleveque as a code owner July 13, 2021 07:21
Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
@yxieca
Copy link
Collaborator

yxieca commented Jul 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SavchukRomanLv
Copy link
Contributor Author

@jleveque can you please check?

@lguohan lguohan merged commit a1f47ab into sonic-net:master Aug 13, 2021
@bingwang-ms
Copy link
Collaborator

Hi @SavchukRomanLv, the test seems to be failing at most platforms.

Traceback (most recent call last):
  File "/azp/agent/_work/8/s/tests/common/plugins/log_section_start/__init__.py", line 73, in _fixture_generator_decorator
    res = next(it)
  File "/azp/agent/_work/8/s/tests/platform_tests/test_auto_negotiation.py", line 62, in recover_ports
    cadidate_test_ports[duthost] = random.sample(all_ports, 3)
  File "/usr/lib/python2.7/random.py", line 325, in sample
    raise ValueError("sample larger than population")
ValueError: sample larger than population

Can you help take a look? Thanks

@SavchukRomanLv
Copy link
Contributor Author

@bingwang-ms this issue fixed in 4055

vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
Signed-off-by: Roman Savchuk <romanx.savchuk@intel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants