-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Mellanox] Update tests related to thermal control #9251
Conversation
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
Cherry-pick PR to 202305: #9667 |
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
@JibinBao I saw below error on my testbed. Looks like the function
|
@bingwang-ms Because this function is in the PR https://github.com/sonic-net/sonic-mgmt/pull/8712,but it is still under review. |
Thanks! The PR #9942 is merged |
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device. Update test_get_fans_target_speed, test_show_platform_fanstatus_mocked and test_show_platform_temperature_mocked Remove tests/platform_tests/mellanox/test_thermal_control.py due to the case is not suitable for the new thermal control mechanism - What is the motivation for this PR? Update tests related to thermal control due to the thermal control mechanism being changed. - How did you do it? Update tests related to thermal control - How did you verify/test it? run tests related to thermal control on the image supporting new thermal control mechanism
Description of PR
Update tests related to thermal control due to the thermal control mechanism being changed for Nvidia device.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update tests related to thermal control due to the thermal control mechanism being changed.
How did you do it?
Update tests related to thermal control
How did you verify/test it?
run tests related to thermal control on the image supporting new thermal control mechanism
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Any
Documentation