Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] Sum up Azp unit test code coverage #209

Merged
merged 17 commits into from
Aug 4, 2021

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Aug 3, 2021

Description

  1. Azp code coverage result is one of the six components by random. This PR summarized all six components test coverage.
  2. Use one container to improve time efficiency.
  3. Parameterize download artifacts.

Motivation and Context

Fix code coverage display error in azp.
Build in multiple containers didn't improve time efficiency.

How Has This Been Tested?

Check code coverage result in Checks/azure pipeline

Additional Information (Optional)

@liushilongbuaa liushilongbuaa changed the base branch from master to 202012 August 3, 2021 07:37
@liushilongbuaa liushilongbuaa changed the base branch from 202012 to master August 3, 2021 07:53
@liushilongbuaa liushilongbuaa changed the title test [CI] Sum up Azp unit test code coverage Aug 3, 2021
@liushilongbuaa liushilongbuaa marked this pull request as ready for review August 3, 2021 10:04
@qiluo-msft
Copy link
Contributor

LGTM. Wait PR build result.

@qiluo-msft qiluo-msft requested a review from lguohan August 4, 2021 08:28
@liushilongbuaa
Copy link
Contributor Author

liushilongbuaa commented Aug 4, 2021

LGTM. Wait PR build result.

result is here: https://dev.azure.com/mssonic/build/_build/results?buildId=26985&view=results
Because I have changed PR check yaml file from 7 parallel jobs into 1 serial job, PR check seems not finished. But actually it is finished.

@liushilongbuaa
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Contributor Author

PR checker will not pass at all. Because 7 old jobs is replaced by 1 new job.
why I changed 7 jobs to 1 job? Because 7 parallel jobs didn't save time. They waste a lot of time downloading the same container and same artifacts.

@qiluo-msft
Copy link
Contributor

The PR checkers are actually passed. Check the Checks page. I will override and merge.

@qiluo-msft qiluo-msft merged commit 8b2227d into sonic-net:master Aug 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants