Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ycabled] fix naming error when error condition is triggered for ycabled CLI handling #302

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Oct 3, 2022

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for
sudo config mux hwmode state active/standby <port>,
in such a scenario we can trigger this
xcvrd_config_hwmode_state_cmd_sts_tbl attribute error.

Description

Motivation and Context

How Has This Been Tested?

Unit-tests and loading the changes on Arista testbed

Additional Information (Optional)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 requested a review from zjswhhh October 3, 2022 20:47
@vdahiya12 vdahiya12 merged commit 23b6970 into sonic-net:master Oct 3, 2022
@vdahiya12 vdahiya12 changed the title [ycabled] fix naming error for error condition for CLI handling [ycabled] fix naming error for error condition for ycabled CLI handling Oct 3, 2022
@vdahiya12 vdahiya12 changed the title [ycabled] fix naming error for error condition for ycabled CLI handling [ycabled] fix naming error when error condition is triggered for ycabled CLI handling Oct 3, 2022
qiluo-msft pushed a commit that referenced this pull request Oct 3, 2022
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for
sudo config mux hwmode state active/standby <port>,
in such a scenario we can trigger this
xcvrd_config_hwmode_state_cmd_sts_tbl attribute error.

Description
Motivation and Context
How Has This Been Tested?
Unit-tests and loading the changes on Arista testbed
yxieca pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for
sudo config mux hwmode state active/standby <port>,
in such a scenario we can trigger this
xcvrd_config_hwmode_state_cmd_sts_tbl attribute error.

Description
Motivation and Context
How Has This Been Tested?
Unit-tests and loading the changes on Arista testbed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants