Fix for bug-21459: Set the initial DPU admin state #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rameshraghupathy could you update fixes tag in description to point to sonic-net/sonic-buildimage#21459? |
@vvolam Done |
sonic-chassisd/scripts/chassisd
Outdated
| try: | ||
| # Get admin state of DPU | ||
| admin_state = self.module_updater.get_module_admin_status(module_name) | ||
| if admin_state == 'empty' and operational_state != ModuleBase.MODULE_STATUS_ONLINE: |
There was a problem hiding this comment.
Suggested change
| if admin_state == 'empty' and operational_state != ModuleBase.MODULE_STATUS_ONLINE: | |
| if admin_state == 'empty' and operational_state == ModuleBase.MODULE_STATUS_ONLINE: |
Shouldnt the admin state be set to down if there is no data in CONFIG_DB and if the module is currently online?
There was a problem hiding this comment.
@gpunathilell Good catch! I would prefer to keep it as "if admin_state == 'empty' and operational_state != ModuleBase.MODULE_STATUS_OFFLINE:" as there are other states besides ONLINE" Hope this works for you.
There was a problem hiding this comment.
Looks good. I will approve once I use this and test. Thank you
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the initial DPU admin state to "down" for DPUs that don't have the "CHASSIS_MODULE" configured. The default is "down"
Fixes: sonic-net/sonic-buildimage#21459
Motivation and Context
The chassisd config change handler is not triggering the config change event the very first time.
How Has This Been Tested?
The new set of smartswitch tests added into sonic-mgmt
Additional Information (Optional)