[Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayurkiv-nvda
force-pushed
the
upstream_dualtor_addition_mac_master
branch
from
1804940 to
0b73b76
Compare
…te if corresponding arg passed to syncd Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
ayurkiv-nvda
force-pushed
the
upstream_dualtor_addition_mac_master
branch
from
0b73b76 to
544c76a
Compare
|
Hello @stephenxs |
stephenxs
approved these changes
Feb 22, 2023
|
Hello @prsunny |
|
Hello @bingwang-ms |
May I know why do we need this attribute in dualtor scenario? |
Need to add additional MAC to VLAN interface on Mellanox SPC-1. It is impossible on SPC-1, so we just add this additional MAC to FDB table, so traffic forwarding will work. SAI use this SAI_ADDITIONAL_MAC_ENABLED attribute to make changes per SPC. |
bingwang-ms
approved these changes
Feb 24, 2023
|
@saiarcot895 @kcudnik can you please help to merge? |
saiarcot895
approved these changes
Feb 27, 2023
yxieca
pushed a commit
that referenced
this pull request
Mar 1, 2023
…te if corresponding arg passed to syncd (#1201) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 7, 2023
…te if corresponding arg passed to syncd (#1201) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-sairedis submodule pointer to include the following: * 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Mar 10, 2023
Update sonic-sairedis submodule pointer to include the following: * 4bd1dc5 Fast reboot finalizer ([sonic-net#1213](sonic-net/sonic-sairedis#1213)) * 749b393 [ci] Fix apt-get install unable locate package issue. ([sonic-net#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([sonic-net#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([sonic-net#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([sonic-net#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 12, 2023
Update sonic-sairedis submodule pointer to include the following: * 4bd1dc5 Fast reboot finalizer ([#1213](sonic-net/sonic-sairedis#1213)) * 749b393 [ci] Fix apt-get install unable locate package issue. ([#1212](sonic-net/sonic-sairedis#1212)) * 886875b [Dual-ToR] update sai.profile with SAI_ADDITIONAL_MAC_ENABLED attribute if corresponding arg passed to syncd ([#1201](sonic-net/sonic-sairedis#1201)) * c58d259 Use new value of STATE_DB FAST_REBOOT entry ([#1196](sonic-net/sonic-sairedis#1196)) * 3808e4c Fix issue: bulk counter feature is disabled ([#1205](sonic-net/sonic-sairedis#1205)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com
Update sai.profile with SAI_ADDITIONAL_MAC_ENABLED=1 if "dual_tor" attr is passed to syncd