-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[syncd] Comparison logic workaround for empty buffer profile #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check issue sonic-net#899 for details.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi Kamil, thanks for this fix. Would it be possible to double commit to 202012 branch also please? |
kcudnik
added a commit
to kcudnik/sonic-sairedis
that referenced
this pull request
Sep 22, 2021
…et#906) * [syncd] WIP buffer profile GET * Add object status serialize method * Add buffer profile get test * [syncd] Allow AsicView return dummy created object * Update aspell * [syncd] Transfer not processed objects to temp view Check issue sonic-net#899 for details. * [tests] Add missing recording file for tests
kcudnik
added a commit
that referenced
this pull request
Sep 26, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…et#906) * [syncd] WIP buffer profile GET * Add object status serialize method * Add buffer profile get test * [syncd] Allow AsicView return dummy created object * Update aspell * [syncd] Transfer not processed objects to temp view Check issue sonic-net#899 for details. * [tests] Add missing recording file for tests
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #899